19945 2012-11-11 23:38:14 +0000 Unnecessary boundary checks in the HZ and ISO-2022-KR encoders 2013-01-07 16:36:58 +0000 1 1 1 Unclassified WHATWG Encoding unspecified All Windows 3.1 RESOLVED FIXED P2 normal Unsorted 1 pub-w3 annevk mike VYV03354 sideshowbarker+encodingspec oldest_to_newest 78213 0 pub-w3 2012-11-11 23:38:14 +0000 The hz-gb-2312 encoder says: > If either lead or trail is not in the range 0x21 to 0x7E, > emit an encoder error. This can only happen if lead < 0x21 or trail < 0x21 (possibly negative); there should be no need to check the upper boundaries. The iso-2022-kr encoder says: > If lead is not in the range 0x21 to 0x46 or trail is not in the range > 0x21 to 0x7E, emit an encoder error. Again, this can only happen if lead < 0x21 or trail < 0x21 (possibly negative). Furthermore: > If lead is not in the range 0x47 to 0x7E or trail is not in the range > 0x21 to 0x7E, emit an encoder error. I believe this cannot happen at all. 80998 1 annevk 2013-01-07 16:26:15 +0000 I added those just in case. I guess I can comment them out for now. 80999 2 annevk 2013-01-07 16:36:58 +0000 https://github.com/whatwg/encoding/commit/47d09ee49d2ad47a435e573e67347766e36c95d2