<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>19881</bug_id>
          
          <creation_ts>2012-11-06 15:05:19 +0000</creation_ts>
          <short_desc>add a &lt;dependency&gt; node to the tests that use HOF feature</short_desc>
          <delta_ts>2013-01-02 14:23:53 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>XPath / XQuery / XSLT</product>
          <component>XQuery 3 &amp; XPath 3 Test Suite</component>
          <version>Working drafts</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sorin Nasoi">spungi</reporter>
          <assigned_to name="O&apos;Neil Delpratt">oneil</assigned_to>
          <cc>g</cc>
    
    <cc>mike</cc>
          
          <qa_contact name="Mailing list for public feedback on specs from XSL and XML Query WGs">public-qt-comments</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>77948</commentid>
    <comment_count>0</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2012-11-06 15:05:19 +0000</bug_when>
    <thetext>The HOF feature is optional, so the tests in FOTS using the HOF feature should have a 
&lt;dependency type=&quot;feature&quot; value=&quot;higher-order-functions&quot; satisfied=&quot;true&quot;/&gt; 
node added.

If I am not missing something, all test cases that satisfy the condition:

matches(fn:data($test-case/fots:test),&quot;(function\-lookup)|(function\-name)|(function\-arity)|(map)|(filter)|(fold\-left)|(fold\-right)|(map\-pairs)|(#[1-9])&quot;))

should be marked with a HOF dependency.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77951</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Kay">mike</who>
    <bug_when>2012-11-06 15:37:31 +0000</bug_when>
    <thetext>I have marked a great many tests with the dependency higherOrderFunctions; see for example

http://dev.w3.org/cvsweb/2011/QT3-test-suite/fn/function-lookup.xml?rev=1.20;content-type=text%2Fplain

where it is defined at test-set level.

If you find specific tests that are missing this dependency - and there are bound to be some - please let us know.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78012</commentid>
    <comment_count>2</comment_count>
      <attachid>1246</attachid>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2012-11-07 21:59:57 +0000</bug_when>
    <thetext>Created attachment 1246
These tests do not have a HOF dependency defined on neither test case nor test set level

If I am not missing something, all the tests with a $test node that returns true for:

matches($test,&quot;(function\-lookup)|(function\-name)|(function\-arity)|(map)|(filter)|(fold\-left)|(fold\-right)|(map\-pairs)|((a-z)*#[0-9])&quot;))

should be marked with a HOF dependency at the test case level.

The mentioned tests are checked for a HOF dependency at both test case and test set level first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78036</commentid>
    <comment_count>3</comment_count>
    <who name="O&apos;Neil Delpratt">oneil</who>
    <bug_when>2012-11-08 10:00:59 +0000</bug_when>
    <thetext>Thanks Sorin for the comprehensive list. I have made the changes and committed them to cvs. 

No change were made to the test-cases: 
require-higher-order-function-4-ns
require-higher-order-function-9-ns
prohibit-higher-order-function-4-ns

According to the description of these the desired affect of switching off the HOF features in the implementation is that we expect an error. 

Just to note that some implementations, like ours, may not be able to switch of features externally! I think Ghislain should look at these test cases again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78067</commentid>
    <comment_count>4</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2012-11-08 18:00:15 +0000</bug_when>
    <thetext>Are you sure you pushed the updates to CVS for all reported cases?

The following have not yet been updated:
&lt;test-set name=&quot;fn-data&quot;&gt;
 &lt;test-case name=&quot;K2-DataFunc-5&quot;/&gt;
&lt;/test-set&gt;
&lt;test-set name=&quot;fn-map&quot;&gt;
 &lt;test-case name=&quot;map-006&quot;/&gt;
&lt;/test-set&gt;

Also please wait a bit before marking the bug as fixed because I will post another list of test-cases that might need HOF dependency added.

The REGEX I used to identify the first list of tests did not catch all concurrences.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78071</commentid>
    <comment_count>5</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2012-11-08 18:30:36 +0000</bug_when>
    <thetext>(In reply to comment #4)
&gt; Are you sure you pushed the updates to CVS for all reported cases?
&gt; 
&gt; The following have not yet been updated:
&gt; &lt;test-set name=&quot;fn-data&quot;&gt;
&gt;  &lt;test-case name=&quot;K2-DataFunc-5&quot;/&gt;
&gt; &lt;/test-set&gt;
&gt; &lt;test-set name=&quot;fn-map&quot;&gt;
&gt;  &lt;test-case name=&quot;map-006&quot;/&gt;
&gt; &lt;/test-set&gt;
&gt; 
&gt; Also please wait a bit before marking the bug as fixed because I will post
&gt; another list of test-cases that might need HOF dependency added.
&gt; 
&gt; The REGEX I used to identify the first list of tests did not catch all
&gt; concurrences.

OK: here are all the cases that should be looked into:

&lt;test set name=&quot;fn-map&quot;&gt;add HOF dependency for the whole test set&lt;/test set&gt;
&lt;test set name=&quot;prod-NamedFunctionRef&quot;&gt;add HOF dependency for the whole test set&lt;/test set&gt;
&lt;test-set name=&quot;fn-data&quot;&gt;
 &lt;test-case name=&quot;K2-DataFunc-5&quot;/&gt;
&lt;/test-set&gt;
&lt;test-set name=&quot;fn-map&quot;&gt;
 &lt;test-case name=&quot;map-006&quot;/&gt;
&lt;/test-set&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80350</commentid>
    <comment_count>6</comment_count>
    <who name="Ghislain Fourny">g</who>
    <bug_when>2012-12-18 14:01:30 +0000</bug_when>
    <thetext>Hi O&apos;Neil,

You are right - the test cases *-ns correspond to the assumption that a given feature (here, HOF) is not supported, and are hence marked with &lt;dependency type=&quot;feature&quot; value=&quot;higherOrderFunctions&quot; satisfied=&quot;false&quot;/&gt;.

If an implementation does not support HOF, it must run these tests to check that it behaves appropriately for require-feature/prohibit-feature.

(In reply to comment #3)
&gt; Thanks Sorin for the comprehensive list. I have made the changes and
&gt; committed them to cvs. 
&gt; 
&gt; No change were made to the test-cases: 
&gt; require-higher-order-function-4-ns
&gt; require-higher-order-function-9-ns
&gt; prohibit-higher-order-function-4-ns
&gt; 
&gt; According to the description of these the desired affect of switching off
&gt; the HOF features in the implementation is that we expect an error. 
&gt; 
&gt; Just to note that some implementations, like ours, may not be able to switch
&gt; of features externally! I think Ghislain should look at these test cases
&gt; again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80351</commentid>
    <comment_count>7</comment_count>
    <who name="Ghislain Fourny">g</who>
    <bug_when>2012-12-18 14:02:59 +0000</bug_when>
    <thetext>I added HOF dependency tags to the following test sets:

fn-map
prod-namedFunctionRef

as well as to the following test cases:

fn-unparsed-text-003
fn-unparsed-text-004
fn-unparsed-text-available-003
fn-unparsed-text-available-004
fn-unparsed-text-lines-003
fn-unparsed-text-lines-004
K2-DataFunc-5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80352</commentid>
    <comment_count>8</comment_count>
    <who name="Ghislain Fourny">g</who>
    <bug_when>2012-12-18 14:07:49 +0000</bug_when>
    <thetext>&gt; Just to note that some implementations, like ours, may not be able to switch
&gt; of features externally! I think Ghislain should look at these test cases
&gt; again.

My understanding is that it is not required to switch off HOF. If an implementation supports HOF and does not provide a means of switching it off externally, I think the semantics of the tags set to false is that it should just skip (ignore) these tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80406</commentid>
    <comment_count>9</comment_count>
    <who name="Ghislain Fourny">g</who>
    <bug_when>2012-12-19 14:00:31 +0000</bug_when>
    <thetext>I have also added a dependency tag on test case contextDecl-055.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>1246</attachid>
            <date>2012-11-07 21:59:57 +0000</date>
            <delta_ts>2012-11-07 21:59:57 +0000</delta_ts>
            <desc>These tests do not have a HOF dependency defined on neither test case nor test set level</desc>
            <filename>tests.xml</filename>
            <type>application/xml</type>
            <size>4091</size>
            <attacher name="Sorin Nasoi">spungi</attacher>
            
              <data encoding="base64">PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHRlc3RzPgogIDx0ZXN0LXNl
dCBuYW1lPSJmbi1hdmFpbGFibGUtZW52aXJvbm1lbnQtdmFyaWFibGVzIj4KICAgIDx0ZXN0LWNh
c2UgbmFtZT0iZm4tYXZhaWxhYmxlLWVudmlyb25tZW50LXZhcmlhYmxlcy0wMDEiLz4KICAgIDx0
ZXN0LWNhc2UgbmFtZT0iZm4tYXZhaWxhYmxlLWVudmlyb25tZW50LXZhcmlhYmxlcy0wMDIiLz4K
ICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tYXZhaWxhYmxlLWVudmlyb25tZW50LXZhcmlhYmxlcy0w
MDMiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tYXZhaWxhYmxlLWVudmlyb25tZW50LXZhcmlh
Ymxlcy0wMDQiLz4KICA8L3Rlc3Qtc2V0PgogIDx0ZXN0LXNldCBuYW1lPSJmbi1kYXRhIj4KICAg
IDx0ZXN0LWNhc2UgbmFtZT0iSzItRGF0YUZ1bmMtNSIvPgogIDwvdGVzdC1zZXQ+CiAgPHRlc3Qt
c2V0IG5hbWU9ImZuLWVudmlyb25tZW50LXZhcmlhYmxlIj4KICAgIDx0ZXN0LWNhc2UgbmFtZT0i
ZW52aXJvbm1lbnQtdmFyaWFibGUtMDAxIi8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImVudmlyb25t
ZW50LXZhcmlhYmxlLTAwMiIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJlbnZpcm9ubWVudC12YXJp
YWJsZS0wMDMiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZW52aXJvbm1lbnQtdmFyaWFibGUtMDA0
Ii8+CiAgPC90ZXN0LXNldD4KICA8dGVzdC1zZXQgbmFtZT0iZm4taGFzLWNoaWxkcmVuIj4KICAg
IDx0ZXN0LWNhc2UgbmFtZT0iZm4taGFzLWNoaWxkcmVuLTAwMSIvPgogICAgPHRlc3QtY2FzZSBu
YW1lPSJmbi1oYXMtY2hpbGRyZW4tMDAyIi8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLWhhcy1j
aGlsZHJlbi0wMDMiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4taGFzLWNoaWxkcmVuLTAwNCIv
PgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1oYXMtY2hpbGRyZW4tMDA4Ii8+CiAgICA8dGVzdC1j
YXNlIG5hbWU9ImZuLWhhcy1jaGlsZHJlbi0wMTAiLz4KICA8L3Rlc3Qtc2V0PgogIDx0ZXN0LXNl
dCBuYW1lPSJmbi1pbm5lcm1vc3QiPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1pbm5lcm1vc3Qt
MDAyIi8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLWlubmVybW9zdC0wMDQiLz4KICAgIDx0ZXN0
LWNhc2UgbmFtZT0iZm4taW5uZXJtb3N0LTAwNSIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1p
bm5lcm1vc3QtMDA3Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLWlubmVybW9zdC0wMTEiLz4K
ICA8L3Rlc3Qtc2V0PgogIDx0ZXN0LXNldCBuYW1lPSJmbi1tYXAiPgogICAgPHRlc3QtY2FzZSBu
YW1lPSJtYXAtMDA2Ii8+CiAgPC90ZXN0LXNldD4KICA8dGVzdC1zZXQgbmFtZT0iZm4tbWFwLXBh
aXJzIj4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJzLTAwMSIvPgogICAgPHRlc3Qt
Y2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDAyIi8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLW1h
cC1wYWlycy0wMDMiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJzLTAwNCIvPgog
ICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDA1Ii8+CiAgICA8dGVzdC1jYXNlIG5h
bWU9ImZuLW1hcC1wYWlycy0wMDYiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJz
LTAwNyIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDA4Ii8+CiAgICA8dGVz
dC1jYXNlIG5hbWU9ImZuLW1hcC1wYWlycy0wMDkiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4t
bWFwLXBhaXJzLTAxMSIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDEyIi8+
CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLW1hcC1wYWlycy0wMTMiLz4KICAgIDx0ZXN0LWNhc2Ug
bmFtZT0iZm4tbWFwLXBhaXJzLTAxNCIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFp
cnMtMDE1Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLW1hcC1wYWlycy0wMTYiLz4KICAgIDx0
ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJzLTAxNyIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJm
bi1tYXAtcGFpcnMtMDE4Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLW1hcC1wYWlycy0wMTki
Lz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJzLTAyMCIvPgogICAgPHRlc3QtY2Fz
ZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDIxIi8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLW1hcC1w
YWlycy0wMjIiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJzLTAyMyIvPgogICAg
PHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDI0Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9
ImZuLW1hcC1wYWlycy0wMjUiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFwLXBhaXJzLTAy
NiIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDI3Ii8+CiAgICA8dGVzdC1j
YXNlIG5hbWU9ImZuLW1hcC1wYWlycy0wMjgiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iZm4tbWFw
LXBhaXJzLTAyOSIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1tYXAtcGFpcnMtMDMwIi8+CiAg
PC90ZXN0LXNldD4KICA8dGVzdC1zZXQgbmFtZT0iZm4tb3V0ZXJtb3N0Ij4KICAgIDx0ZXN0LWNh
c2UgbmFtZT0iZm4tb3V0ZXJtb3N0LTAwMiIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJmbi1vdXRl
cm1vc3QtMDA0Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9ImZuLW91dGVybW9zdC0wMDUiLz4KICAg
IDx0ZXN0LWNhc2UgbmFtZT0iZm4tb3V0ZXJtb3N0LTAwNyIvPgogICAgPHRlc3QtY2FzZSBuYW1l
PSJmbi1vdXRlcm1vc3QtMDExIi8+CiAgPC90ZXN0LXNldD4KICA8dGVzdC1zZXQgbmFtZT0ib3At
Y29uY2F0Ij4KICAgIDx0ZXN0LWNhc2UgbmFtZT0ib3AtY29uY2F0LTE4Ii8+CiAgPC90ZXN0LXNl
dD4KICA8dGVzdC1zZXQgbmFtZT0icHJvZC1DYXN0RXhwci5zY2hlbWEiPgogICAgPHRlc3QtY2Fz
ZSBuYW1lPSJDYXN0QXMtVW5pb25UeXBlLTciLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iQ2FzdEFz
LVVuaW9uVHlwZS04Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9IkNhc3RBcy1VbmlvblR5cGUtMTMi
Lz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iQ2FzdEFzLVVuaW9uVHlwZS0xNCIvPgogICAgPHRlc3Qt
Y2FzZSBuYW1lPSJDYXN0QXMtVW5pb25UeXBlLTE4Ii8+CiAgICA8dGVzdC1jYXNlIG5hbWU9IkNh
c3RBcy1VbmlvblR5cGUtMjQiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iQ2FzdEFzLVVuaW9uVHlw
ZS0yNiIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJDYXN0QXMtVW5pb25UeXBlLTMwIi8+CiAgICA8
dGVzdC1jYXNlIG5hbWU9IkNhc3RBcy1VbmlvblR5cGUtMzEiLz4KICAgIDx0ZXN0LWNhc2UgbmFt
ZT0iQ2FzdEFzLVVuaW9uVHlwZS0zMiIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJDYXN0QXMtTGlz
dFR5cGUtOSIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJDYXN0QXMtTGlzdFR5cGUtMTAiLz4KICAg
IDx0ZXN0LWNhc2UgbmFtZT0iQ2FzdEFzLUxpc3RUeXBlLTE4Ii8+CiAgICA8dGVzdC1jYXNlIG5h
bWU9IkNhc3RBcy1MaXN0VHlwZS0xOSIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJDYXN0QXMtTGlz
dFR5cGUtMjQiLz4KICAgIDx0ZXN0LWNhc2UgbmFtZT0iQ2FzdEFzLUxpc3RUeXBlLTI2Ii8+CiAg
ICA8dGVzdC1jYXNlIG5hbWU9IkNhc3RBcy1MaXN0VHlwZS0yNyIvPgogIDwvdGVzdC1zZXQ+CiAg
PHRlc3Qtc2V0IG5hbWU9InByb2QtTW9kdWxlSW1wb3J0Ij4KICAgIDx0ZXN0LWNhc2UgbmFtZT0i
bW9kdWxlcy1wdWItcHJpdi0zNyIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJtb2R1bGVzLXB1Yi1w
cml2LTM4Ii8+CiAgPC90ZXN0LXNldD4KICA8dGVzdC1zZXQgbmFtZT0icHJvZC1SZXF1aXJlUHJv
aGliaXRGZWF0dXJlIj4KICAgIDx0ZXN0LWNhc2UgbmFtZT0icmVxdWlyZS1oaWdoZXItb3JkZXIt
ZnVuY3Rpb24tNC1ucyIvPgogICAgPHRlc3QtY2FzZSBuYW1lPSJyZXF1aXJlLWhpZ2hlci1vcmRl
ci1mdW5jdGlvbi05LW5zIi8+CiAgICA8dGVzdC1jYXNlIG5hbWU9InByb2hpYml0LWhpZ2hlci1v
cmRlci1mdW5jdGlvbi00LW5zIi8+CiAgPC90ZXN0LXNldD4KPC90ZXN0cz4=
</data>

          </attachment>
      

    </bug>

</bugzilla>