19800 2012-10-31 18:58:50 +0000 "If the number of bytes in mask is not equal to length, return false" can't ever happen? 2012-11-01 17:19:10 +0000 1 1 1 Unclassified WHATWG MIME unspecified PC All RESOLVED FIXED P4 normal Unsorted 1 ian gphemsley ian mike sideshowbarker+mimespec oldest_to_newest 77538 0 ian 2012-10-31 18:58:50 +0000 In step 5 of the "Pattern matching algorithm": "5. If the number of bytes in mask is not equal to length, return false" .../length/ is equal to the number of bytes in /pattern/, which had better always be the same length as /mask/! 77541 1 gphemsley 2012-10-31 19:18:31 +0000 This was a built-in test to prevent against typos in the spec or in the implementation. I included it as a safety net, but if you think it'd be better without it, I can remove it. 77597 2 ian 2012-10-31 22:25:22 +0000 It'll cause implementors to add code that has no effect. I recommend commenting it out at best. After all, if the patterns are ever wrong, then you don't want the implementations to skip them, you want them to tell you to fix them! What I sometimes do is add non-normative statements that work a bit like assertions, e.g. "At this point /length/ will also equal the number of bytes in mask". 77687 3 gphemsley 2012-11-01 17:19:10 +0000 (In reply to comment #2) > What I sometimes do is add non-normative statements that work a bit like > assertions, e.g. "At this point /length/ will also equal the number of bytes > in mask". I opted to modify step 4 to read: "Let length be the number of bytes in pattern, which is equal to the number of bytes in mask." https://github.com/whatwg/mimesniff/commit/5c0c4c9259c6837837ef575b512fb41d3ff3824a