<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>19302</bug_id>
          
          <creation_ts>2012-10-05 21:05:19 +0000</creation_ts>
          <short_desc>Comments extension causes an infinite loop</short_desc>
          <delta_ts>2012-10-29 08:59:21 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>webplatform.org</product>
          <component>infrastructure</component>
          <version>unspecified</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Lane">rlane32</reporter>
          <assigned_to name="Markus Glaser">glaser</assigned_to>
          <cc>glaser</cc>
    
    <cc>jonathan</cc>
    
    <cc>schepers</cc>
    
    <cc>team-webplatform-admin</cc>
          
          <qa_contact name="public-webplatform-bugs list">public-webplatform-bugs</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>75402</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Lane">rlane32</who>
    <bug_when>2012-10-05 21:05:19 +0000</bug_when>
    <thetext>This is likely only for users who aren&apos;t email confirmed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75404</commentid>
    <comment_count>1</comment_count>
    <who name="Ryan Lane">rlane32</who>
    <bug_when>2012-10-05 21:12:43 +0000</bug_when>
    <thetext>See: http://docs.webplatform.org/w/images/2/2e/comments-stacktrace.txt</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75439</commentid>
    <comment_count>2</comment_count>
    <who name="Markus Glaser">glaser</who>
    <bug_when>2012-10-06 00:26:48 +0000</bug_when>
    <thetext>I found a hook look in OutputPageBeforeHTML: Comments extension binds to OutputPageBeforeHTML. This in turn calls SemanticForms, which adds text to the wgOut object, which in turn calls OutputPageBeforeHTML.

In order to fix it, I put a flag in the main rendering function in Comments that indicates that rendering is already in progress and prevents another execution of the hooked function.

For testing, I created a new account and did not confirm any email. Then I went to the problematic article and added a comment. This worked for me.

As of now, the fix is only applied to the test system. I&apos;d be happy if someone else tests and confirms the bug is resolved.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77239</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Garbee">jonathan</who>
    <bug_when>2012-10-29 02:02:45 +0000</bug_when>
    <thetext>Is this still an issue?  I haven&apos;t seen any issues with the commenting system.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>