18613 2012-08-17 22:55:41 +0000 [Templates]: Section 7 Parsing HTML Templates needs to be re-written 2012-09-07 04:41:07 +0000 1 1 1 Unclassified WebAppsWG HISTORICAL - Component Model unspecified PC All RESOLVED FIXED P2 normal --- 15476 1 rafaelw tross dglazkov rafaelw tross public-webapps-bugzilla oldest_to_newest 72389 0 rafaelw 2012-08-17 22:55:41 +0000 To be reflect the prior consensus (on public-webapps) about implied context parsing. The basic idea is this: While parsing children of the template element, act as if IN_HEAD, but append any produced nodes to the template element's content. When the first "determining" start tag is encountered, set the context element based on the indentity of that tag, reset the insertion mode appropriately and continue. Non-determining start tags must include: template, style, script, link. 72395 1 tross 2012-08-17 23:54:40 +0000 We'll also need an explicit clause for non-whitespace text (else we'll end up implying a closing HEAD tag). Basically this clause will add non-whitespace text to the DOM without exiting implied context parsing (so we'll keep searching for a "determining" start tag afterward). 72709 2 tross 2012-08-24 18:12:46 +0000 http://dvcs.w3.org/hg/webcomponents/rev/557c7e693458 72951 3 rafaelw 2012-08-28 23:45:46 +0000 I implemented the current spec text (including "clear the stack back to XXX", and I have some questions: Here are html5lib test cases that illustrate the issues: // Does naked template go into <head> or <body> -- as is, it goes into <head> #data <template>Hello</template> #errors #document | <html> | <head> | <body> | <template> | "Hello" // Can template exist as a child of <html> -- as is, it gets put into <head> #data <html><template><div> #errors #document | <html> | <template> | <div> // Can template exist as a child of <colgroup> -- as is, no #data <table><colgroup><template>Hello #errors #document | <html> | <head> | <body> | <table> | <colgroup> | <template> | "Hello" // Can template exist as a child of <frameset> -- as is, no #data <frameset><template><frame> #errors #document | <html> | <head> | <body> | <frameset> | <template> | <frame> // Reset insertion mode picks InBody for </head>, which is wrong for this case. -- as is, this actually hits a series of assertions, and I'm pretty sure it's wrong. #data <head><template><div></div></template></head> #errors #document | <html> | <head> | <template> | <div> // Should "in cell" be modified to "close the cell" on </template> (e.g. with </table>, </tbody>, </tfoot>, </thead>, </tr>) -- as is, </tr> wil lbe ignored and <div> appended to <td> #data <body><template><td></tr><div></template> #errors #document | <html> | <head> | <body> | <template> | <td> | <div> 73024 4 rafaelw 2012-08-29 22:29:25 +0000 Also, just to make sure this is what we want: #data <body><template><tr><div></div></tr></template> #errors #document | <html> | <head> | <body> | <template> | <tr> | <div> Note that the div is foster parented *after* the <tr>, not before. 73025 5 rafaelw 2012-08-29 22:31:48 +0000 Likewise this one: #data <body><template><div><tr></tr></div></template> #errors #document | <html> | <head> | <body> | <template> | <div> (throws away the <tr> -- which I think makes sense). 73076 6 rafaelw 2012-08-30 17:59:29 +0000 Decisions: On Thu, Aug 30, 2012 at 10:52 AM, Rafael Weinstein <rafaelw@google.com> wrote: > // Does naked template go into <head> or <body> -- as is, it goes into <head> > #data > <template>Hello</template> > #errors > #document > | <html> > | <head> > | <body> > | <template> > | "Hello" This is correct (analog is <script>) > > // Can template exist as a child of <html> -- as is, it gets put into <head> > #data > <html><template><div> > #errors > #document > | <html> > | <template> > | <div> > This is correct (analog is <script>) > // Can template exist as a child of <colgroup> -- as is, no > #data > <table><colgroup><template>Hello > #errors > #document > | <html> > | <head> > | <body> > | <table> > | <colgroup> > | <template> > | "Hello" We need parser edits for this. Relevant test which should pass is // Can template exist as a child of <colgroup> -- as is, no #data <table><colgroup><template><col> #errors #document | <html> | <head> | <body> | <table> | <colgroup> | <template> | <col> > > // Can template exist as a child of <frameset> -- as is, no > #data > <frameset><template><frame> > #errors > #document > | <html> > | <head> > | <body> > | <frameset> > | <template> > | <frame> We need parser edits for this. Relevant test which should pass is #data <frameset><template><frame> #errors #document | <html> | <head> | <frameset> | <template> | <frame> > > // Reset insertion mode picks InBody for </head>, which is wrong for this case. > -- as is, this actually hits a series of assertions, and I'm pretty sure it's > wrong. > #data > <head><template><div></div></template></head> > #errors > #document > | <html> > | <head> > | <template> > | <div> Step 11 of reset insertion mode appropriately should be: If node is a head element and node is the context element, then switch the insertion mode to "in body" ("in body"! not "in head"!) and abort these steps. (fragment case) otherwise, switch the insertion mode to "in head" and abort these steps. > > // Should "in cell" be modified to "close the cell" on </template> (e.g. with > </table>, </tbody>, </tfoot>, </thead>, </tr>) -- as is, </tr> wil lbe ignored > and <div> appended to <td> > #data > <body><template><td></tr><div></template> > #errors > #document > | <html> > | <head> > | <body> > | <template> > | <td> > | <div> This is correct, but we need spec text that http://dev.w3.org/html5/spec/parsing.html#has-an-element-in-table-scope includes <template> > > Also, just to make sure this is what we want: > > #data > <body><template><tr><div></div></tr></template> > #errors > #document > | <html> > | <head> > | <body> > | <template> > | <tr> > | <div> > > Note that the div is foster parented *after* the <tr>, not before. Correct behavior. > > Likewise this one: > > #data > <body><template><div><tr></tr></div></template> > #errors > #document > | <html> > | <head> > | <body> > | <template> > | <div> > > (throws away the <tr> -- which I think makes sense). Correct behavior. 73200 7 tross 2012-09-04 21:42:01 +0000 http://dvcs.w3.org/hg/webcomponents/rev/6b0813f30f10 73372 8 rafaelw 2012-09-06 21:42:42 +0000 For the colgroup case to work (e.g.: #data <table><colgroup><template><col> #errors #document | <html> | <head> | <body> | <table> | <colgroup> | <template> | <col> ), template contents mode needs to set the insertion mode to in column group when a col tag is encountered. 73374 9 rafaelw 2012-09-06 22:26:23 +0000 For the frameset case to work, template contents mode needs to set the insertion mode to in frameset when a frame tag is encountered. 73375 10 rafaelw 2012-09-06 22:50:52 +0000 The in head edit to reset insertion mode should read: Modify the step which begins "If node is a head element..." to be: If node is a head element and node is the context element, then switch the insertion mode to "in body" ("in body"! not "in head") and abort these steps (fragment case). Otherwise, switch the insertion mode to "in head", and abort these steps. 73376 11 rafaelw 2012-09-06 23:08:25 +0000 To clarify > // Should "in cell" be modified to "close the cell" on </template> (e.g. with > </table>, </tbody>, </tfoot>, </thead>, </tr>) -- as is, </tr> wil lbe ignored > and <div> appended to <td> > #data > <body><template><td></tr><div></template> > #errors > #document > | <html> > | <head> > | <body> > | <template> > | <td> > | <div> This is correct, but we need spec text that http://dev.w3.org/html5/spec/parsing.html#has-an-element-in-table-scope includes <template> Should actually be: #data <body><template><td></tr><div></template> #errors #document | <html> | <head> | <body> | <template> | <td> | <div> 73385 12 rafaelw 2012-09-07 00:29:36 +0000 also, it's probably worth clarifying for in cell mode: An end tag whose tag name is one of: "table", "tbody", "tfoot", "thead", "tr" If the stack of open elements does not have an element in table scope with the same tag name as that of the token (which can only happen for "tbody", "tfoot" and "thead", or in the fragment case), then this is a parse error and the token must be ignored. Otherwise, close the cell (see below) and reprocess the current token. --- That this can now happen if a template contents is currently being parsed (webkit was hitting an assertion which I had to relax by checking if templateTag is in tableScope. 73386 13 rafaelw 2012-09-07 00:43:42 +0000 note that i have patch for these edits which I'll submit as soon as I gain write access. 73391 14 rafaelw 2012-09-07 04:41:07 +0000 http://dvcs.w3.org/hg/webcomponents/rev/923f79e27d75