<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>16424</bug_id>
          
          <creation_ts>2012-03-18 17:14:30 +0000</creation_ts>
          <short_desc>Invalid return value specified for the pre-instert algorithm</short_desc>
          <delta_ts>2012-03-18 18:45:26 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebAppsWG</product>
          <component>DOM</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>manish.tripathi.777</reporter>
          <assigned_to name="Ms2ger">Ms2ger</assigned_to>
          <cc>mike</cc>
    
    <cc>Ms2ger</cc>
    
    <cc>www-dom</cc>
          
          <qa_contact>public-webapps-bugzilla</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>65716</commentid>
    <comment_count>0</comment_count>
    <who name="">manish.tripathi.777</who>
    <bug_when>2012-03-18 17:14:30 +0000</bug_when>
    <thetext>According to http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-node-pre-insert , step 8, pre-insert algorithm returns a &quot;child&quot;, but in the context of that particular alrogitm, a &quot;child&quot; is a reference node, NOT the inserted node.

Therefore, step 8 should read: &quot;8. Return &lt;i&gt;node&lt;/i&gt;.&quot;

This is critical, because the value returned by pre-insert algoritm is passed on to and returned by the Node.appendChild(node) and Node.insertBefore(node, child) method.

If implemented as is, Node.appendChild(node) will ALWAYS return null, whereas it must return the inserted node.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>65717</commentid>
    <comment_count>1</comment_count>
    <who name="Ms2ger">Ms2ger</who>
    <bug_when>2012-03-18 18:45:26 +0000</bug_when>
    <thetext>Good catch, thanks.

https://bitbucket.org/ms2ger/dom-core/changeset/1f02e4a8b80c
https://dvcs.w3.org/hg/domcore/rev/1f02e4a8b80c</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>