1640 2005-07-15 21:58:53 +0000 [FS] editorial: 4.7.1.1 Attributes 2007-01-16 17:30:25 +0000 1 1 1 Unclassified XPath / XQuery / XSLT Formal Semantics 1.0 Last Call drafts All All CLOSED FIXED P2 minor --- 1 jmdyck simeon public-qt-comments oldest_to_newest 4721 0 jmdyck 2005-07-15 21:58:53 +0000 4.7.1.1 Attributes "Like literal XML element constructors, literal XML attribute constructors ..." s/literal XML/direct/g ? (grammar) It would be nice if the relevant productions were moved from 4.7.1 to this section. DirAttributeList DirAttributeValue QuotAttrValueContent AposAttrValueContent QuotAttrContentChar AposAttrContentChar EscapeQuot EscapeApos Notation "for the normalization of the content of direct attribute constructors." Delete "the content of". Two of them are only concerned with content, but []_Attribute is concerned with larger things. Norm "The normalization rules for attributes ignore namespace-declaration attributes" Maybe change "for attributes" to "in this section". "An AttributeList" Change to "A DirAttributeList". Norm / rule 1 / LHS Insert an ellipsis. 'Attributen' is preceded by two double-quotes. Delete one. Norm / rule (1|2|3) AttributeValue Use of the Formal symbol AttributeValue is completely inappropriate. Change '"' AttributeValue '"' to DirAttributeValue Norm / rule 3 / RHS Change 'AttributeValue' to 'DirAttributeValue'. Norm / rule 3 Change [[ Prefix:LocalPart ]]_Expr to just Prefix:LocalPart. (see 4.7.1 / Norm / rule (3|4) in Bug 1627) "attribute-content unit" There is no definition for this term. "because the rule ... are applied" s/are/is/ Norm / rule (4|5) "AttributeValueContent" The symbol 'AttributeValueContent' is not defined. At least change it to 'AttributeContentUnit' to be consistent with the prose. Norm / rule (4|5) [[]]_AttributeContent-unit (Similar comments as for _ElementContent-unit in Bug 1627.) This construct only appears on the LHS of mapping rules, so there's nothing to invoke it. Probably the RHS of rule 3 is supposed to invoke it rather than [[]]_AttributeContent. The subscript-names 'AttributeContent' and 'AttributeContent-unit' seem to be assigned each other's semantics. That is, the '-unit' subscript should be concerned with normalizing a single unit, and the other subscript with normalizing the whole content. And 'Unit' would match your naming convention better than '-unit'. Norm / rule 5 / LHS "AttributeValueContent1 ..., AttributeValueContentn Delete comma. Norm / rule 5 / RHS "fs:item-sequence-to-untypedAtomic( ... )" This function takes a single argument (of type item*), so there should be an extra pair of parentheses around what currently appear to be its args. "by normalizing each individual expression in its expression sequence and then construct a sequence" s/construct/constructing/ 4728 1 jmdyck 2005-07-15 23:09:54 +0000 (Also...) Norm / rule 1 "AttributeValue0" The subscript should be "1". 9250 2 simeon 2006-04-15 22:51:04 +0000 All comments processed as suggested except for #2 to keep the grammar locations in XQuery 1.0 and FS consistent. Some of the main changes include: * Added grammar productions for 'AttributeContentUnit' * Switched the role of []AttributeContent and []AttributeContentUnit - Jerome 12211 3 jmdyck 2006-09-29 21:44:04 +0000 I said: > > "An AttributeList" > Change to "A DirAttributeList". It's now "An DirAttributeList", so you still need to change "An" to "A". 12893 4 simeon 2006-11-09 22:40:05 +0000 Fixed. - Jerome