16300 2012-03-10 03:08:47 +0000 Remove 'skew' from transform functions 2012-07-30 12:32:24 +0000 1 1 1 Unclassified CSS Transforms unspecified PC All RESOLVED FIXED P2 normal --- 18436 1 dschulze dschulze ayg cmarrin dbaron dino dschulze eoconnor smfr public-css-bugzilla oldest_to_newest 65275 0 dschulze 2012-03-10 03:08:47 +0000 Remove 'skew' from transform functions. See discussions on mailing lists: http://lists.w3.org/Archives/Public/www-style/2009Mar/0287.html http://lists.w3.org/Archives/Public/public-fx/2012JanMar/0156.html 65363 1 ayg 2012-03-12 18:31:18 +0000 Is WebKit willing to drop support here? I filed a Gecko bug to see if Gecko is willing: https://bugzilla.mozilla.org/show_bug.cgi?id=734953 65364 2 smfr 2012-03-12 18:33:55 +0000 Yep, once unprefixed. 65365 3 dschulze 2012-03-12 18:47:25 +0000 (In reply to comment #2) > Yep, once unprefixed. We can not differ between prefixed or unprefixed in the CSSParser for transform, can we? Why not remove it once the change is in a new WD? (sorry, maybe a bit to off topic) 65366 4 smfr 2012-03-12 18:54:23 +0000 (In reply to comment #3) > (In reply to comment #2) > > Yep, once unprefixed. > > We can not differ between prefixed or unprefixed in the CSSParser for > transform, can we? Why not remove it once the change is in a new WD? (sorry, > maybe a bit to off topic) Sure we can. 65450 5 1092 dschulze 2012-03-13 18:46:14 +0000 Created attachment 1092 Remove skew This patch removes skew and adapts the mathematical description. Note that I also created new images for the forumlar that are not part of the diff. 65471 6 dschulze 2012-03-13 22:19:28 +0000 (In reply to comment #5) > Created attachment 1092 [details] > Remove skew > > This patch removes skew and adapts the mathematical description. Note that I > also created new images for the forumlar that are not part of the diff. Added a bug report for WebKit: https://bugs.webkit.org/show_bug.cgi?id=81039 It looks like I misunderstood Simon at the beginning. To clarify: WebKit will not support 'skew()' for the unprefixed property, once the function was removed from the spec. WebKit will _still_ support 'skew()' for the prefixed version, even after unprefixing. 65532 7 ayg 2012-03-14 17:43:06 +0000 (In reply to comment #5) > Created attachment 1092 [details] > Remove skew > > This patch removes skew and adapts the mathematical description. Note that I > also created new images for the forumlar that are not part of the diff. I think we should require that browsers not support skew(), like by saying """ Previous versions of this specification defined a transformation called skew() that took one or two angles as arguments. User agents must not support such a transformation without vendor-specific prefixes <http://www.w3.org/TR/CSS21/syndata.html#vendor-keywords>. """ Otherwise, we might have a situation where implementations don't bother dropping support. Authors might then use skew(), find that it only works in some browsers, and blame the remaining browsers for not supporting it. We should be clear that all browsers have to drop support for the unprefixed property, so that we maintain interop. 65534 8 smfr 2012-03-14 17:44:09 +0000 We've never done this in a spec before, as far as I know. It's OK to have a testcase for it, but I don't think the spec needs to say it. 65538 9 dschulze 2012-03-14 17:55:04 +0000 (In reply to comment #8) > We've never done this in a spec before, as far as I know. It's OK to have a > testcase for it, but I don't think the spec needs to say it. I agree with Simon. 65542 10 ayg 2012-03-14 18:14:17 +0000 I don't think we can fairly test it if it's not in the spec. If you prefer, we could require that UAs not support any unprefixed transforms other than those specified in the Transforms spec, and test only for skew(). But if we don't require they don't support it, how can we fail UAs that do support it? 65544 11 smfr 2012-03-14 18:16:21 +0000 This is like saying that browsers that support "display: frilly" don't comply. You can't make exclusive tests. 65548 12 ayg 2012-03-14 18:33:29 +0000 Normally I'd agree, but the spec has required this for a long time and all browsers implemented it. Either all browsers should keep support, or they should all drop support. If we're not going to require dropping support, I'd prefer we require browsers keep support rather than saying nothing either way. 65550 13 dschulze 2012-03-14 18:38:17 +0000 (In reply to comment #12) > Normally I'd agree, but the spec has required this for a long time and all > browsers implemented it. Either all browsers should keep support, or they > should all drop support. If we're not going to require dropping support, I'd > prefer we require browsers keep support rather than saying nothing either way. No spec required the support for skew so far. No Transform spec ever reached CR and even there it could still be possible to drop things. Also we might add it later again with a different mathematical concept. Like Simon said, we should not exclude stuff. 65557 14 ayg 2012-03-14 19:03:24 +0000 So if the spec doesn't require lack of support, should the tests test for lack of support (comment #8) or not? 65565 15 smfr 2012-03-14 19:46:36 +0000 No, I don't think so. 65567 16 ayg 2012-03-14 20:07:01 +0000 Well, I guess I'm outnumbered. 65569 17 dbaron 2012-03-14 20:16:59 +0000 I think the spec shouldn't say anything, but the test suite should test for non-support of skew(). 65570 18 dschulze 2012-03-14 20:21:16 +0000 (In reply to comment #17) > I think the spec shouldn't say anything, but the test suite should test for > non-support of skew(). Yes, I don't think that this is a big deal. If for some reason the spec changes, the test can get updated. There might still be concerns on how to run the test. If the tests won't include prefixes, we are fine. If they do, then WebKit for instance would fail. But as far as I heard, tests shouldn't include prefixes. If at all, they will be added by the testing harness. So it is a question how the testing harness handles prefixes. 65629 19 dschulze 2012-03-15 21:42:34 +0000 If no one opposes, I'll land the patch in an hour. 65645 20 dschulze 2012-03-16 01:05:38 +0000 I'll take care of the test. 65670 21 ayg 2012-03-16 17:03:22 +0000 For reference, the commits were: http://dvcs.w3.org/hg/csswg/rev/fe20a7d427c1 http://dvcs.w3.org/hg/csswg/rev/28ba69e9cf34 Tests updated: http://hg.csswg.org/test/rev/596325f22c8c 1092 2012-03-13 18:46:14 +0000 2012-03-13 18:46:14 +0000 Remove skew skew.patch text/plain 4332 dschulze ZGlmZiAtciBmNzZkNDliOThhMWMgY3NzMy10cmFuc2Zvcm1zL1RyYW5zZm9ybXMuc3JjLmh0bWwK LS0tIGEvY3NzMy10cmFuc2Zvcm1zL1RyYW5zZm9ybXMuc3JjLmh0bWwJVHVlIE1hciAxMyAxMTox OTo0NyAyMDEyIC0wNzAwCisrKyBiL2NzczMtdHJhbnNmb3Jtcy9UcmFuc2Zvcm1zLnNyYy5odG1s CVR1ZSBNYXIgMTMgMTE6Mzk6MjUgMjAxMiAtMDcwMApAQCAtMTYyNiwyMiArMTYyNiwxNiBAQAog ICAgICAgICAgICAgICAgICAgd291bGQgY2F1c2UgZWxlbWVudHMgdG8gYXBwZWFyIHJvdGF0ZWQg b25lLXF1YXJ0ZXIgb2YgYSB0dXJuIGluIHRoZSBjbG9ja3dpc2UgZGlyZWN0aW9uLgogICAgICAg ICAgICAgICAgIDwvZGQ+CiAgICAgICAgICAgICAgICAgPGR0PgotICAgICAgICAgICAgICAgICAg PGNvZGUgY2xhc3M9ImNzcyI+c2tldygmbHQ7YW5nbGUmZ3Q7WywgJmx0O2FuZ2xlJmd0O10pPC9j b2RlPgotICAgICAgICAgICAgICAgIDwvZHQ+Ci0gICAgICAgICAgICAgICAgPGRkPgotICAgICAg ICAgICAgICAgICAgc3BlY2lmaWVzIGEgPGEgaHJlZj0iI1NrZXdEZWZpbmVkIj4yRCBza2V3PC9h PiBieSBbYXgsYXldIGZvciBYIGFuZCBZLiBJZiB0aGUgc2Vjb25kIHBhcmFtZXRlciBpcyBub3Qg cHJvdmlkZWQsIGl0IGlzIGhhcyBhIHplcm8gdmFsdWUuCi0gICAgICAgICAgICAgICAgPC9kZD4K LSAgICAgICAgICAgICAgICA8ZHQ+CiAgICAgICAgICAgICAgICAgICA8Y29kZSBjbGFzcz0iY3Nz Ij5za2V3WCgmbHQ7YW5nbGUmZ3Q7KTwvY29kZT4KICAgICAgICAgICAgICAgICA8L2R0PgogICAg ICAgICAgICAgICAgIDxkZD4KLSAgICAgICAgICAgICAgICAgIHNwZWNpZmllcyBhIDxhIGhyZWY9 IiNTa2V3RGVmaW5lZCI+MkQgc2tldyB0cmFuc2Zvcm1hdGlvbiBhbG9uZyB0aGUgWCBheGlzPC9h PiBieSB0aGUgZ2l2ZW4gYW5nbGUuIFRoZSBza2V3IHZlY3RvciBpcyBbYXgsMF0uCisgICAgICAg ICAgICAgICAgICBzcGVjaWZpZXMgYSA8YSBocmVmPSIjU2tld1hEZWZpbmVkIj4yRCBza2V3IHRy YW5zZm9ybWF0aW9uIGFsb25nIHRoZSBYIGF4aXM8L2E+IGJ5IHRoZSBnaXZlbiBhbmdsZS4KICAg ICAgICAgICAgICAgICA8L2RkPgogICAgICAgICAgICAgICAgIDxkdD4KICAgICAgICAgICAgICAg ICAgIDxjb2RlIGNsYXNzPSJjc3MiPnNrZXdZKCZsdDthbmdsZSZndDspPC9jb2RlPgogICAgICAg ICAgICAgICAgIDwvZHQ+CiAgICAgICAgICAgICAgICAgPGRkPgotICAgICAgICAgICAgICAgICAg c3BlY2lmaWVzIGEgPGEgaHJlZj0iI1NrZXdEZWZpbmVkIj4yRCBza2V3IHRyYW5zZm9ybWF0aW9u IGFsb25nIHRoZSBZIGF4aXM8L2E+IGJ5IHRoZSBnaXZlbiBhbmdsZS4gVGhlIHNrZXcgdmVjdG9y IGlzIFswLGF5XS4KKyAgICAgICAgICAgICAgICAgIHNwZWNpZmllcyBhIDxhIGhyZWY9IiNTa2V3 WURlZmluZWQiPjJEIHNrZXcgdHJhbnNmb3JtYXRpb24gYWxvbmcgdGhlIFkgYXhpczwvYT4gYnkg dGhlIGdpdmVuIGFuZ2xlLgogICAgICAgICAgICAgICAgIDwvZGQ+CiAgICAgICAgICAgICAgIDwv ZGw+CiAKQEAgLTE3NzIsNyArMTc2Niw3IEBACiAgICAgICAgICAgICAgICAgICA8dWw+CiAgICAg ICAgICAgICAgICAgICAgIDxsaT4KICAgICAgICAgICAgICAgICAgICAgICBGb3IgdHJhbnNsYXRl LCB0cmFuc2xhdGUzZCwgdHJhbnNsYXRlWCwgdHJhbnNsYXRlWSwgdHJhbnNsYXRlWiwgc2NhbGUs Ci0gICAgICAgICAgICAgICAgICAgICAgc2NhbGUzZCwgc2NhbGVYLCBzY2FsZVksIHNjYWxlWiwg cm90YXRlLCByb3RhdGVYLCByb3RhdGVZLCByb3RhdGVaLCBza2V3LCBza2V3WAorICAgICAgICAg ICAgICAgICAgICAgIHNjYWxlM2QsIHNjYWxlWCwgc2NhbGVZLCBzY2FsZVosIHJvdGF0ZSwgcm90 YXRlWCwgcm90YXRlWSwgcm90YXRlWiwgc2tld1gKICAgICAgICAgICAgICAgICAgICAgICBhbmQg c2tld1kgZnVuY3Rpb25zOgogICAgICAgICAgICAgICAgICAgICAgICAgPHVsPgogICAgICAgICAg ICAgICAgICAgICAgICAgICA8bGk+CkBAIC0xODIzLDcgKzE4MTcsNyBAQAogICAgICAgICAgICAg ICAgICAgICAgICAgVGhlIGlkZW50aXR5IGZ1bmN0aW9ucyBhcmUgdHJhbnNsYXRlKDApLCB0cmFu c2xhdGUzZCgwLCAwLCAwKSwKICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zbGF0ZVgoMCks IHRyYW5zbGF0ZVkoMCksIHRyYW5zbGF0ZVooMCksIHNjYWxlKDEpLCBzY2FsZTNkKDEsIDEsIDEp LAogICAgICAgICAgICAgICAgICAgICAgICAgc2NhbGVYKDEpLCBzY2FsZVkoMSksIHNjYWxlWigx KSwgcm90YXRlKDApLCByb3RhdGUzZCgxLCAxLCAxLCAwKSwKLSAgICAgICAgICAgICAgICAgICAg ICAgIHJvdGF0ZVgoMCksIHJvdGF0ZVkoMCksIHJvdGF0ZVooMCksIHNrZXcoMCksIHNrZXdYKDAp LCBza2V3WSgwKSwKKyAgICAgICAgICAgICAgICAgICAgICAgIHJvdGF0ZVgoMCksIHJvdGF0ZVko MCksIHJvdGF0ZVooMCksIHNrZXdYKDApLCBza2V3WSgwKSwKICAgICAgICAgICAgICAgICAgICAg ICAgIG1hdHJpeCgxLCAwLCAwLCAxLCAwLCAwKSBhbmQKICAgICAgICAgICAgICAgICAgICAgICAg IG1hdHJpeDNkKDEsIDAsIDAsIDAsIDAsIDEsIDAsIDAsIDAsIDAsIDEsIDAsIDAsIDAsIDAsIDEp LgogICAgICAgICAgICAgICAgICAgICAgIDwvcD4KQEAgLTIwNjcsMTEgKzIwNjEsMTcgQEAKICAg ICAgICAgICAgICAgICAgICAgd2l0aCB2ZWN0b3IgWzAsMCwxXSBhbmQgcGFyYW1ldGVyIDxlbT5h bHBoYTwvZW0+LgogICAgICAgICAgICAgICAgICAgPC9wPgogICAgICAgICAgICAgICAgIDwvbGk+ Ci0gICAgICAgICAgICAgICAgPGxpIGlkPSJTa2V3RGVmaW5lZCI+CisgICAgICAgICAgICAgICAg PGxpIGlkPSJTa2V3WERlZmluZWQiPgogICAgICAgICAgICAgICAgICAgPHA+Ci0gICAgICAgICAg ICAgICAgICAgIEEgMkQgc2tldyB0cmFuc2Zvcm1hdGlvbiB3aXRoIHRoZSBwYXJhbWV0ZXJzIDxl bT5hbHBoYTwvZW0+IGFuZCA8ZW0+YmV0YTwvZW0+IGlzIGVxdWl2YWxlbnQgdG8gdGhlIG1hdHJp eDoKKyAgICAgICAgICAgICAgICAgICAgQSAyRCBza2V3IHRyYW5zZm9ybWF0aW9uIGFsb25nIHRo ZSBYIGF4aXMgd2l0aCB0aGUgcGFyYW1ldGVyIDxlbT5hbHBoYTwvZW0+IGlzIGVxdWl2YWxlbnQg dG8gdGhlIG1hdHJpeDoKICAgICAgICAgICAgICAgICAgIDwvcD4KLSAgICAgICAgICAgICAgICAg IDxpbWcgc3JjPSJza2V3LnBuZyIgYWx0PSJcYmVnaW57Ym1hdHJpeH0gMSAmIFx0YW4oXGFscGhh KSAmIDAgJiAwIFxcIFx0YW4oXGJldGEpICYgMSAmIDAgJiAwIFxcIDAgJiAwICYgMSAmIDAgXFwg MCAmIDAgJiAwICYgMSBcZW5ke2JtYXRyaXh9IiB3aWR0aD0iMjA1IiBoZWlnaHQ9IjEwNiI+Cisg ICAgICAgICAgICAgICAgICA8aW1nIHNyYz0ic2tld1gucG5nIiBhbHQ9IlxiZWdpbntibWF0cml4 fSAxICYgXHRhbihcYWxwaGEpICYgMCAmIDAgXFwgMCAmIDEgJiAwICYgMCBcXCAwICYgMCAmIDEg JiAwIFxcIDAgJiAwICYgMCAmIDEgXGVuZHtibWF0cml4fSIgd2lkdGg9IjE1NSIgaGVpZ2h0PSIx MDYiPgorICAgICAgICAgICAgICAgIDwvbGk+CisgICAgICAgICAgICAgICAgPGxpIGlkPSJTa2V3 WURlZmluZWQiPgorICAgICAgICAgICAgICAgICAgPHA+CisgICAgICAgICAgICAgICAgICAgIEEg MkQgc2tldyB0cmFuc2Zvcm1hdGlvbiBhbG9uZyB0aGUgWSBheGlzIHdpdGggdGhlIHBhcmFtZXRl ciA8ZW0+YmV0YTwvZW0+IGlzIGVxdWl2YWxlbnQgdG8gdGhlIG1hdHJpeDoKKyAgICAgICAgICAg ICAgICAgIDwvcD4KKyAgICAgICAgICAgICAgICAgIDxpbWcgc3JjPSJza2V3WS5wbmciIGFsdD0i XGJlZ2lue2JtYXRyaXh9IDEgJiAwICYgMCAmIDAgXFwgXHRhbihcYmV0YSkgJiAxICYgMCAmIDAg XFwgMCAmIDAgJiAxICYgMCBcXCAwICYgMCAmIDAgJiAxIFxlbmR7Ym1hdHJpeH0iIHdpZHRoPSIx NTUiIGhlaWdodD0iMTA2Ij4KICAgICAgICAgICAgICAgICA8L2xpPgogICAgICAgICAgICAgICAg IDxsaSBpZD0iVHJhbnNsYXRlM2REZWZpbmVkIj4KICAgICAgICAgICAgICAgICAgIDxwPgpkaWZm IC1yIGY3NmQ0OWI5OGExYyBjc3MzLXRyYW5zZm9ybXMvc2tldy5wbmcKQmluYXJ5IGZpbGUgY3Nz My10cmFuc2Zvcm1zL3NrZXcucG5nIGhhcyBjaGFuZ2VkCmRpZmYgLXIgZjc2ZDQ5Yjk4YTFjIGNz czMtdHJhbnNmb3Jtcy9za2V3WC5wbmcKQmluYXJ5IGZpbGUgY3NzMy10cmFuc2Zvcm1zL3NrZXdY LnBuZyBoYXMgY2hhbmdlZApkaWZmIC1yIGY3NmQ0OWI5OGExYyBjc3MzLXRyYW5zZm9ybXMvc2tl d1kucG5nCkJpbmFyeSBmaWxlIGNzczMtdHJhbnNmb3Jtcy9za2V3WS5wbmcgaGFzIGNoYW5nZWQK