15792 2012-01-30 12:15:20 +0000 [Shadow]: cloneNode should throw DATA_CLONE_ERR 2012-01-31 23:30:37 +0000 1 1 1 Unclassified WebAppsWG HISTORICAL - Component Model unspecified PC All RESOLVED FIXED P2 normal --- 14978 1 hayato dglazkov public-webapps-bugzilla oldest_to_newest 63326 0 hayato 2012-01-30 12:15:20 +0000 The latest draft spec says: Invoking the cloneNode() method on a ShadowRoot instance must always throw a HIERARCHY_REQUEST_ERR exception. But according to Node's IDL definition, http://www.w3.org/TR/DOM-Level-2-Core/core.html#ID-1950641247 Node cloneNode(in boolean deep); It seems cloneNode must not throw DOMException. Is it okay to throw DOMException in case of ShadowRoot? 63342 1 dglazkov 2012-01-30 17:30:44 +0000 Sure, why not? If you'd like, I can redefine cloneNode on ShadowRoot in the IDL? 63365 2 hayato 2012-01-30 23:32:05 +0000 If that's okay and commonly used in IDL world, I do not mind. :) I just afraid that it seems to violate substitution principle of inheritance in general. Fo example, if DOMException should be considered a 'checked' exception (I borrowed the word from Java) , it violates substitution principal. Subclass can not override a method so that it add a checked Exception which is not declared in superclass's signature. In IDL world, I am not sure whether we should keep this rule or not. I just want to make sure that is okay in IDL. (In reply to comment #1) > Sure, why not? If you'd like, I can redefine cloneNode on ShadowRoot in the > IDL? 63369 3 dglazkov 2012-01-30 23:42:34 +0000 The thing is that cloneNode _does_ indeed throw an exception for DocumentFragments: http://www.w3.org/TR/2011/WD-domcore-20110531/#clone I think the IDL is just wrong. I'll file a bug against domcore. 63387 4 hayato 2012-01-31 04:55:53 +0000 Thank you. I agree that either the spec or the implementation must be fixed if DocumentFragment's cloneNode might throw DOMException. I cannot find any spec that DocumentFragment's cloneNode may throw DOMException. (In reply to comment #3) > The thing is that cloneNode _does_ indeed throw an exception for > DocumentFragments: http://www.w3.org/TR/2011/WD-domcore-20110531/#clone > > I think the IDL is just wrong. I'll file a bug against domcore. 63476 5 dglazkov 2012-01-31 23:27:47 +0000 Renaming the bug to keep in sync with DOM Core. 63477 6 dglazkov 2012-01-31 23:30:37 +0000 http://dvcs.w3.org/hg/webcomponents/rev/75b4cc4d3efa