15611 2012-01-18 17:35:27 +0000 [Shadow]: Consider element.createShadowRoot as API for creating ShadowRoot objects. 2012-11-27 19:11:38 +0000 1 1 1 Unclassified WebAppsWG HISTORICAL - Component Model unspecified PC All RESOLVED FIXED P2 normal --- 18428 1 esprehn dglazkov dglazkov public-webapps-bugzilla oldest_to_newest 62864 0 esprehn 2012-01-18 17:35:27 +0000 Read only access to every ShadowRoot must be provided for each element to support tools. Without it something like Readability wouldn't be possible because there's no way to access the content of the page that's inside the shadow DOM. This also makes tools like Google Feedback impossible to build because there's no way to access the nodes in the shadow DOM for rendering in screenshots. Without the addition of CanvasRenderingContext2D #renderElement() this cripples HTML screenshot tools. In general the API appears to be backwards because the ShadowRoot constructor is invoked directly instead of being created through a factory method like createElement(). root = element.createShadowRoot() => new root. element.shadowRoots => list of roots. 62866 1 dglazkov 2012-01-18 18:26:43 +0000 Thanks for the feedback! There are two issues reported here: (In reply to comment #0) > Read only access to every ShadowRoot must be provided for each element to > support tools. Without it something like Readability wouldn't be possible > because there's no way to access the content of the page that's inside the > shadow DOM. > > This also makes tools like Google Feedback impossible to build because there's > no way to access the nodes in the shadow DOM for rendering in screenshots. > Without the addition of CanvasRenderingContext2D #renderElement() this cripples > HTML screenshot tools. This is bug 15409. > > In general the API appears to be backwards because the ShadowRoot constructor > is invoked directly instead of being created through a factory method like > createElement(). > > root = element.createShadowRoot() => new root. > element.shadowRoots => list of roots. This is new. I'll repurpose the bug to track this. So far, my thinking is that "new ShadowRoot(..)" is shorter, and doesn't require extending HTMLElement API surface. 77772 2 esprehn 2012-11-02 20:42:12 +0000 (In reply to comment #1) > ... > This is new. I'll repurpose the bug to track this. So far, my thinking is > that "new ShadowRoot(..)" is shorter, and doesn't require extending > HTMLElement API surface. We're already extending the API surface with public shadows, and having a constructor that has side effects is very weird. I can't think of any other place in the platform where constructing an object has side effects like this (and it's usually considered a code smell). It's particularly weird in the implementation of WebKit as we call ShadowRoot::create(this) often and discard the return value which is non-obvious to someone looking at the code. Once we expose public shadows people may do the same thing: function doSomething() { // Not obvious this does anything. new ShadowRoot(element); } element.oldestShadowRoot.appendChild(...); so I'd propose addShadowRoot() which is the same number of characters and models what's going on better. element.addShadowRoot() 78494 3 dglazkov 2012-11-20 00:05:32 +0000 http://dvcs.w3.org/hg/webcomponents/rev/e0dfe2ac8104 78941 4 dglazkov 2012-11-27 19:11:38 +0000 *** Bug 17447 has been marked as a duplicate of this bug. ***