15533 2012-01-12 12:51:33 +0000 Index check in selection.extend() should be done before node type test. 2012-01-13 17:05:35 +0000 1 1 1 Unclassified WebAppsWG HISTORICAL - HTML Editing APIs unspecified All All RESOLVED FIXED http://dvcs.w3.org/hg/editing/raw-file/tip/selecttest/extend.html P2 normal --- 1 stighal ayg mike public-webapps sideshowbarker+html-editing-api oldest_to_newest 62596 0 1066 stighal 2012-01-12 12:51:33 +0000 Created attachment 1066 Test patch, index According to the Selection spec for extend [1], the checking of offset compared to parentNode's length should be done before setting the new boundary points for the range [2] which would trigger the node type exception for doctype. In the selecttest/extend.html tests there are a few tests that expect the browser to throw an INVALID_NODE_TYPE_ERR, where in fact the INDEX_SIZE_ERR exception should be checked and thrown first. Patch attached. [1] http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-extend [2] http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-range-bp-set 62604 1 ayg 2012-01-12 17:13:08 +0000 Actually, it seems like I should just reference DOM4's "set the start or end" algorithm for simplicity. This results in throwing InvalidNodeTypeError first. This: document.createRange().setStart(document.doctype, -13); throws InvalidNodeTypeError in Firefox 12.0a1 and Chrome 17 dev, per DOM4; and IndexSizeError in IE9 and Opera Next 12.00 alpha, not per DOM4. We should be consistent and throw InvalidNodeTypeError for extend() just like setStart(). I've changed the spec to reference DOM4's algorithm, which I believe makes the tests correct: http://dvcs.w3.org/hg/editing/rev/0ef300a5c14f Please tell me if this isn't satisfactory. Thanks! 62652 2 stighal 2012-01-13 09:00:37 +0000 (In reply to comment #1) ... > Please tell me if this isn't satisfactory. Thanks! The changes look very good. Thank you for quick response. Just FYI, I'm currently rewriting the Range and Selection code in Opera, and upcoming versions will match the spec, more or less, to the letter. 62669 3 ayg 2012-01-13 17:05:35 +0000 Great! Opera's Range/Selection implementation was always a not-so-good match for the other browsers I tested, and I hope my spec/tests are helpful in improving that. Please give me any further feedback you have and I'll try to respond ASAP. 1066 2012-01-12 12:51:33 +0000 2012-01-12 12:51:33 +0000 Test patch, index w3_686.patch text/plain 1639 stighal IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIHN0aWdoYWxAb3BlcmEuY29tCiMgRGF0ZSAxMzI2 MzY3NjUwIC0zNjAwCiMgQnJhbmNoIHN0aWdoYWxfcGF0Y2hlc18wMQojIE5vZGUgSUQgNDEwYjJi MWVmYjkxYmY4YjNkZmE0YWQ0OTI2ZjZmNTFhNWEzNGU2YwojIFBhcmVudCAgYzQ5YzJkYTNjODQx YTU4YTIzZGFhMjBjMzVjMzY1Mzg0MGIxNjg1MApBY2NvcmRpbmcgdG8gdGhlIFNlbGVjdGlvbiBz cGVjIGZvciBleHRlbmQgWzFdLCB0aGUgY2hlY2tpbmcgb2Ygb2Zmc2V0IGNvbXBhcmVkCnRvIHBh cmVudE5vZGUncyBsZW5ndGggc2hvdWxkIGJlIGRvbmUgYmVmb3JlIHNldHRpbmcgdGhlIG5ldyBi b3VuZGFyeSBwb2ludHMKZm9yIHRoZSByYW5nZSB3aGljaCB3b3VsZCB0cmlnZ2VyIHRoZSBub2Rl IHR5cGUgZXhjZXB0aW9uIGZvciBkb2N0eXBlLgoKWzFdIGh0dHA6Ly9kdmNzLnczLm9yZy9oZy9l ZGl0aW5nL3Jhdy1maWxlL3RpcC9lZGl0aW5nLmh0bWwjZG9tLXNlbGVjdGlvbi1leHRlbmQKCmRp ZmYgLXIgYzQ5YzJkYTNjODQxIC1yIDQxMGIyYjFlZmI5MSBzZWxlY3R0ZXN0L2V4dGVuZC5odG1s Ci0tLSBhL3NlbGVjdHRlc3QvZXh0ZW5kLmh0bWwJVGh1IEphbiAxMiAxMTozMjo1NyAyMDEyICsw MTAwCisrKyBiL3NlbGVjdHRlc3QvZXh0ZW5kLmh0bWwJVGh1IEphbiAxMiAxMjoyNzozMCAyMDEy ICswMTAwCkBAIC0xMDgsNiArMTA4LDEzIEBACiAJCXJldHVybjsKIAl9CiAKKwlpZiAob2Zmc2V0 IDwgMCB8fCBvZmZzZXQgPiBnZXROb2RlTGVuZ3RoKG5vZGUpKSB7CisJCWFzc2VydF90aHJvd3Mo IklOREVYX1NJWkVfRVJSIiwgZnVuY3Rpb24oKSB7CisJCQlzZWxlY3Rpb24uZXh0ZW5kKG5vZGUs IG9mZnNldCk7CisJCX0sICJleHRlbmQoKSB0byBhbiBvZmZzZXQgdGhhdCdzIG5lZ2F0aXZlIG9y IGdyZWF0ZXIgdGhhbiBub2RlIGxlbmd0aCAoIiArIGdldE5vZGVMZW5ndGgobm9kZSkgKyAiKSBt dXN0IHRocm93IElOREVYX1NJWkVfRVJSIik7CisJCXJldHVybjsKKwl9CisKIAlpZiAobm9kZS5u b2RlVHlwZSA9PSBOb2RlLkRPQ1VNRU5UX1RZUEVfTk9ERSkgewogCQlhc3NlcnRfdGhyb3dzKCJJ TlZBTElEX05PREVfVFlQRV9FUlIiLCBmdW5jdGlvbigpIHsKIAkJCXNlbGVjdGlvbi5leHRlbmQo bm9kZSwgb2Zmc2V0KTsKQEAgLTExNSwxMyArMTIyLDYgQEAKIAkJcmV0dXJuOwogCX0KIAotCWlm IChvZmZzZXQgPCAwIHx8IG9mZnNldCA+IGdldE5vZGVMZW5ndGgobm9kZSkpIHsKLQkJYXNzZXJ0 X3Rocm93cygiSU5ERVhfU0laRV9FUlIiLCBmdW5jdGlvbigpIHsKLQkJCXNlbGVjdGlvbi5leHRl bmQobm9kZSwgb2Zmc2V0KTsKLQkJfSwgImV4dGVuZCgpIHRvIGFuIG9mZnNldCB0aGF0J3MgbmVn YXRpdmUgb3IgZ3JlYXRlciB0aGFuIG5vZGUgbGVuZ3RoICgiICsgZ2V0Tm9kZUxlbmd0aChub2Rl KSArICIpIG11c3QgdGhyb3cgSU5ERVhfU0laRV9FUlIiKTsKLQkJcmV0dXJuOwotCX0KLQogCXZh ciByYW5nZSA9IHNlbGVjdGlvbi5nZXRSYW5nZUF0KHNlbGVjdGlvbi5yYW5nZUNvdW50IC0gMSk7 CiAJdmFyIHJhbmdlUm9vdCA9IGZ1cnRoZXN0QW5jZXN0b3IocmFuZ2Uuc3RhcnRDb250YWluZXIp OwogCXZhciBub2RlUm9vdCA9IGZ1cnRoZXN0QW5jZXN0b3Iobm9kZSk7Cg==