15532 2012-01-12 12:47:00 +0000 Collapsing or extending to a ProcessingInstruction should be OK 2012-01-12 15:24:17 +0000 1 1 1 Unclassified WebAppsWG HISTORICAL - HTML Editing APIs unspecified All All RESOLVED FIXED http://dvcs.w3.org/hg/editing/raw-file/tip/selecttest/collapse.html P2 normal --- 1 stighal ayg mike public-webapps sideshowbarker+html-editing-api oldest_to_newest 62595 0 1065 stighal 2012-01-12 12:47:00 +0000 Created attachment 1065 Test patch, PI In the selecttest/collapse.html and selecttest/extend.html tests there are a few tests that expect the browser to throw an INVALID_NODE_TYPE_ERR when trying to collapse or extend to a PI. According to the Selection [1] and Range [2] specs, it is not illegal to do that, so I think the tests are wrong. Patch attached. [1] http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-collapse http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-extend [2] http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-range-bp-set 62598 1 ayg 2012-01-12 15:24:17 +0000 Thanks! Accepted: http://dvcs.w3.org/hg/editing/rev/9ca0bc5d4285 These checks date back from before DOM4 declared ProcessingInstructions to be CharacterData. They weren't allowed as Range endpoints because they were an annoying special case. Now they're allowed just like Text and Comment, with no extra spec effort, but the tests weren't updated. 1065 2012-01-12 12:47:00 +0000 2012-01-12 12:47:00 +0000 Test patch, PI w3_685.patch text/plain 2025 stighal IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIHN0aWdoYWxAb3BlcmEuY29tCiMgRGF0ZSAxMzI2 MzY0Mzc3IC0zNjAwCiMgQnJhbmNoIHN0aWdoYWxfcGF0Y2hlc18wMQojIE5vZGUgSUQgYzQ5YzJk YTNjODQxYTU4YTIzZGFhMjBjMzVjMzY1Mzg0MGIxNjg1MAojIFBhcmVudCAgNDA1OGUwYTI5NjVm ZTRhYTY1OGFlZDA0OWIwODFhMTZiNTk2NzIwMwpDb2xsYXBzaW5nIGEgc2VsZWN0aW9uIG9uIGEg UHJvY2Vzc2luZ0luc3RydWN0aW9uIFsxXSwgb3IgZXh0ZW5kaW5nIGEgc2VsZWN0aW9uCnRvIGEg UEkgWzJdLCBzaG91bGQgbm90IHRocm93IGFuIGV4Y2VwdGlvbiwgbmVpdGhlciBhY2NvcmRpbmcg dG8gdGhlIFNlbGVjdGlvbgpzcGVjIG5vciB0aGUgRE9NIFJhbmdlIHNwZWMgZm9yIHNldHRpbmcg Ym91bmRhcnkgcG9pbnRzIFszXS4KClsxXQpodHRwOi8vZHZjcy53My5vcmcvaGcvZWRpdGluZy9y YXctZmlsZS90aXAvZWRpdGluZy5odG1sI2RvbS1zZWxlY3Rpb24tY29sbGFwc2UKWzJdCmh0dHA6 Ly9kdmNzLnczLm9yZy9oZy9lZGl0aW5nL3Jhdy1maWxlL3RpcC9lZGl0aW5nLmh0bWwjZG9tLXNl bGVjdGlvbi1leHRlbmQKWzNdCmh0dHA6Ly9kdmNzLnczLm9yZy9oZy9kb21jb3JlL3Jhdy1maWxl L3RpcC9PdmVydmlldy5odG1sI2NvbmNlcHQtcmFuZ2UtYnAtc2V0CgpkaWZmIC1yIDQwNThlMGEy OTY1ZiAtciBjNDljMmRhM2M4NDEgc2VsZWN0dGVzdC9jb2xsYXBzZS5odG1sCi0tLSBhL3NlbGVj dHRlc3QvY29sbGFwc2UuaHRtbAlXZWQgSmFuIDExIDEzOjM4OjMyIDIwMTIgLTA3MDAKKysrIGIv c2VsZWN0dGVzdC9jb2xsYXBzZS5odG1sCVRodSBKYW4gMTIgMTE6MzI6NTcgMjAxMiArMDEwMApA QCAtMTQsMTEgKzE0LDEwIEBACiAJCXNlbGVjdGlvbi5hZGRSYW5nZShhZGRlZFJhbmdlKTsKIAl9 CiAKLQlpZiAocG9pbnRbMF0ubm9kZVR5cGUgPT0gTm9kZS5ET0NVTUVOVF9UWVBFX05PREUKLQl8 fCBwb2ludFswXS5ub2RlVHlwZSA9PSBOb2RlLlBST0NFU1NJTkdfSU5TVFJVQ1RJT05fTk9ERSkg eworCWlmIChwb2ludFswXS5ub2RlVHlwZSA9PSBOb2RlLkRPQ1VNRU5UX1RZUEVfTk9ERSkgewog CQlhc3NlcnRfdGhyb3dzKCJJTlZBTElEX05PREVfVFlQRV9FUlIiLCBmdW5jdGlvbigpIHsKIAkJ CXNlbGVjdGlvbi5jb2xsYXBzZShwb2ludFswXSwgcG9pbnRbMV0pOwotCQl9LCAiTXVzdCB0aHJv dyBJTlZBTElEX05PREVfVFlQRV9FUlIgd2hlbiBjb2xsYXBzZSgpaW5nIGlmIHRoZSBub2RlIGlz IGEgRG9jdW1lbnRUeXBlIG9yIFByb2Nlc3NpbmdJbnN0cnVjdGlvbiIpOworCQl9LCAiTXVzdCB0 aHJvdyBJTlZBTElEX05PREVfVFlQRV9FUlIgd2hlbiBjb2xsYXBzZSgpaW5nIGlmIHRoZSBub2Rl IGlzIGEgRG9jdW1lbnRUeXBlIik7CiAJCXJldHVybjsKIAl9CiAKZGlmZiAtciA0MDU4ZTBhMjk2 NWYgLXIgYzQ5YzJkYTNjODQxIHNlbGVjdHRlc3QvZXh0ZW5kLmh0bWwKLS0tIGEvc2VsZWN0dGVz dC9leHRlbmQuaHRtbAlXZWQgSmFuIDExIDEzOjM4OjMyIDIwMTIgLTA3MDAKKysrIGIvc2VsZWN0 dGVzdC9leHRlbmQuaHRtbAlUaHUgSmFuIDEyIDExOjMyOjU3IDIwMTIgKzAxMDAKQEAgLTEwOCwx MSArMTA4LDEwIEBACiAJCXJldHVybjsKIAl9CiAKLQlpZiAobm9kZS5ub2RlVHlwZSA9PSBOb2Rl LkRPQ1VNRU5UX1RZUEVfTk9ERQotCXx8IG5vZGUubm9kZVR5cGUgPT0gTm9kZS5QUk9DRVNTSU5H X0lOU1RSVUNUSU9OX05PREUpIHsKKwlpZiAobm9kZS5ub2RlVHlwZSA9PSBOb2RlLkRPQ1VNRU5U X1RZUEVfTk9ERSkgewogCQlhc3NlcnRfdGhyb3dzKCJJTlZBTElEX05PREVfVFlQRV9FUlIiLCBm dW5jdGlvbigpIHsKIAkJCXNlbGVjdGlvbi5leHRlbmQobm9kZSwgb2Zmc2V0KTsKLQkJfSwgImV4 dGVuZCgpIHRvIGEgZG9jdHlwZSBvciBQSSBtdXN0IHRocm93IElOVkFMSURfTk9ERV9UWVBFX0VS UiIpOworCQl9LCAiZXh0ZW5kKCkgdG8gYSBkb2N0eXBlIG11c3QgdGhyb3cgSU5WQUxJRF9OT0RF X1RZUEVfRVJSIik7CiAJCXJldHVybjsKIAl9CiAK