15356 2011-12-28 15:47:36 +0000 NodeFilter callback 2011-12-29 12:30:53 +0000 1 1 1 Unclassified WebAppsWG DOM unspecified PC All RESOLVED FIXED P2 normal --- 1 annevk annevk ap ayg bugs cam darin ian jonas jrossi mike mjs Ms2ger ojan travil www-dom zcorpan public-webapps-bugzilla oldest_to_newest 62101 0 annevk 2011-12-28 15:47:36 +0000 I would like your help in figuring out how we should define NodeFilter per the latest Web IDL as implementations might have to change. http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#nodefilter http://dev.w3.org/2006/webapi/WebIDL/ The simplest I could come up with was to put all the constants on an exposed NodeFilter interface and put the acceptNode() method on a separate NodeFilterCallback callback interface. 62116 1 cam 2011-12-28 23:59:42 +0000 Or you could just write it as callback interface NodeFilter { const ...; ... unsigned short acceptNode(Node node); }; since callback interfaces that have constants on them do get an interface object (but not prototype property on there). http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces The only problem with that is if you want to disallow { acceptNode: ... } being used as a NodeFilter. If compatibility doesn't require it, then doing what you suggest would be OK. 62124 2 Ms2ger 2011-12-29 12:24:10 +0000 Why would we want to get rid of { acceptNode: ... }? 62125 3 annevk 2011-12-29 12:30:53 +0000 Ah, nice Cameron! https://bitbucket.org/ms2ger/dom-core/changeset/1e5db6bdc60b