14421 2011-10-11 05:52:25 +0000 Possible error in canvas Philip test 2d.path.stroke.prune.arc 2012-08-15 12:36:20 +0000 1 1 1 Unclassified HTML WG testsuite unspecified All All RESOLVED FIXED P2 normal --- 1 benwells zhiqiang.zhang bugs excors ian jorritv mike mikelawther Ms2ger noel.gordon public-html-admin public-html-wg-issue-tracking tmpsantos public-html-bugzilla oldest_to_newest 58034 0 benwells 2011-10-11 05:52:25 +0000 This test is checking that no zero length segments are removed when using arcTo and arc. The code for checking arc is: ctx.beginPath(); ctx.moveTo(50, 25); ctx.arc(50, 25, 10, 0, 0, false); ctx.stroke(); I think this should create a line from (50, 25) to the start of the arc, which in this case will be (60, 25): the center of the circle is (50, 25), the radius is 10 and the start angle is 0. I believe arc call should be changed to: ctx.arc(40, 25, 10, 0, 0, false); 58035 1 benwells 2011-10-11 05:54:16 +0000 Relevant section of the canvas spec: http://www.w3.org/TR/2dcontext/#dom-context-2d-arc 59768 2 benwells 2011-11-09 01:44:20 +0000 Any takers? Let me know if there is somewhere more appropriate I should log this. 63195 3 ian 2012-01-27 18:26:21 +0000 The method is defined as only adding the straight line if the path already contains a subpath, which it doesn't in this case. 66146 4 benwells 2012-03-27 22:49:21 +0000 (In reply to comment #3) > The method is defined as only adding the straight line if the path already > contains a subpath, which it doesn't in this case. The moveTo call before the arc will create a sub path: http://www.w3.org/TR/2dcontext/#dom-context-2d-moveto "The moveTo(x, y) method must create a new subpath with the specified point as its first (and only) point." More code from the test is below. The sections with arcTo and arc are, I believe, intended to be equivalent. However as the arguments are treated slightly differently they are not. The first two arguments to arcTo describe a point on the arc. The first two arguments to arc describe the center of the arc. ctx.fillStyle = '#0f0'; ctx.fillRect(0, 0, 100, 50); ctx.strokeStyle = '#f00'; ctx.lineWidth = 100; ctx.lineCap = 'round'; ctx.lineJoin = 'round'; ctx.beginPath(); ctx.moveTo(50, 25); ctx.arcTo(50, 25, 150, 25, 10); ctx.stroke(); ctx.beginPath(); ctx.moveTo(50, 25); ctx.arc(50, 25, 10, 0, 0, false); ctx.stroke(); _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255"); 72164 5 1174 zhiqiang.zhang 2012-08-14 15:37:13 +0000 Created attachment 1174 Fix on ctx.moveTo() Fix this issue as http://trac.webkit.org/browser/trunk/LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html 72173 6 ian 2012-08-14 23:46:47 +0000 Please disregard comment 3, I was indeed incorrect. 72196 7 jorritv 2012-08-15 11:46:08 +0000 I can confirm that that patch is correct per spec. (And Philip had already made that change in the unapproved version: http://dvcs.w3.org/hg/html/rev/f7e11f44274c) 72198 8 tmpsantos 2012-08-15 12:08:57 +0000 Is it ok to apply zqzhang's patch on the approved test? Any objection? 72199 9 Ms2ger 2012-08-15 12:20:04 +0000 Yes, please do. 72200 10 tmpsantos 2012-08-15 12:36:20 +0000 Fixed at https://dvcs.w3.org/hg/html/rev/f64be2d08dcd 1174 2012-08-14 15:37:13 +0000 2012-08-14 15:37:13 +0000 Fix on ctx.moveTo() FixtoBug14421.patch text/plain 869 zhiqiang.zhang IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIFpoaXFpYW5nIFpoYW5nIDx6aGlxaWFuZy56aGFu Z0BpbnRlbC5jb20+CiMgRGF0ZSAxMzQ0OTUyMjczIC0yODgwMAojIE5vZGUgSUQgZmIwZTU3Mjk2 ZmJhNjYyZDdmZTdiODQ0N2Q2ZWQ5ZmIwYmI2ZTBhNAojIFBhcmVudCAgMGE5MzAyNWQzYTIzNjMz NGM0YmY5NmQ5ZGNiM2M2MzUwY2ZhMzVmZApGaXggQnVnIDE0NDIxIC0gUG9zc2libGUgZXJyb3Ig aW4gY2FudmFzIFBoaWxpcCB0ZXN0IDJkLnBhdGguc3Ryb2tlLnBydW5lLmFyYwoKZGlmZiAtLWdp dCBhL3Rlc3RzL2FwcHJvdmVkL2NhbnZhcy8yZC5wYXRoLnN0cm9rZS5wcnVuZS5hcmMuaHRtbCBi L3Rlc3RzL2FwcHJvdmVkL2NhbnZhcy8yZC5wYXRoLnN0cm9rZS5wcnVuZS5hcmMuaHRtbAotLS0g YS90ZXN0cy9hcHByb3ZlZC9jYW52YXMvMmQucGF0aC5zdHJva2UucHJ1bmUuYXJjLmh0bWwKKysr IGIvdGVzdHMvYXBwcm92ZWQvY2FudmFzLzJkLnBhdGguc3Ryb2tlLnBydW5lLmFyYy5odG1sCkBA IC0zMCwxNyArMzAsMTcgQEAgY3R4LmxpbmVDYXAgPSAncm91bmQnOwogY3R4LmxpbmVKb2luID0g J3JvdW5kJzsKIAogY3R4LmJlZ2luUGF0aCgpOwogY3R4Lm1vdmVUbyg1MCwgMjUpOwogY3R4LmFy Y1RvKDUwLCAyNSwgMTUwLCAyNSwgMTApOwogY3R4LnN0cm9rZSgpOwogCiBjdHguYmVnaW5QYXRo KCk7Ci1jdHgubW92ZVRvKDUwLCAyNSk7CitjdHgubW92ZVRvKDYwLCAyNSk7CiBjdHguYXJjKDUw LCAyNSwgMTAsIDAsIDAsIGZhbHNlKTsKIGN0eC5zdHJva2UoKTsKIAogX2Fzc2VydFBpeGVsKGNh bnZhcywgNTAsMjUsIDAsMjU1LDAsMjU1LCAiNTAsMjUiLCAiMCwyNTUsMCwyNTUiKTsKIAogCiB9 KTsKIDwvc2NyaXB0Pgo=