<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>14199</bug_id>
          
          <creation_ts>2011-09-18 18:24:14 +0000</creation_ts>
          <short_desc>IDBVersionChangeEvent still uses DOMString for version</short_desc>
          <delta_ts>2012-01-24 04:57:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebAppsWG</product>
          <component>Indexed Database API</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kyle Huey">me</reporter>
          <assigned_to name="Eliot Graff">eliotgra</assigned_to>
          <cc>eliotgra</cc>
    
    <cc>jonas</cc>
    
    <cc>mike</cc>
    
    <cc>Ms2ger</cc>
    
    <cc>public-webapps</cc>
          
          <qa_contact>public-webapps-bugzilla</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>56948</commentid>
    <comment_count>0</comment_count>
    <who name="Kyle Huey">me</who>
    <bug_when>2011-09-18 18:24:14 +0000</bug_when>
    <thetext>After the recent setVersion changes it should be using long long.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57421</commentid>
    <comment_count>1</comment_count>
    <who name="Kyle Huey">me</who>
    <bug_when>2011-09-27 16:43:38 +0000</bug_when>
    <thetext>Actually, it should use &apos;any&apos; for newVersion, since in a deleteDatabase call it is null.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59461</commentid>
    <comment_count>2</comment_count>
    <who name="Eliot Graff">eliotgra</who>
    <bug_when>2011-11-02 00:41:05 +0000</bug_when>
    <thetext>Will make long long.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59487</commentid>
    <comment_count>3</comment_count>
    <who name="Eliot Graff">eliotgra</who>
    <bug_when>2011-11-02 15:01:09 +0000</bug_when>
    <thetext>Fixed in the 1 November Editor&apos;s Draft:

interface IDBVersionChangeEvent : Event {
    readonly attribute unsigned long long oldVersion;
    readonly attribute unsigned long long newVersion;
    void initIDBVersionChangeEvent (DOMString typeArg, boolean canBubbleArg, boolean cancelableArg, long long oldVersion, long long newVersion);
};

I think newVersion should be long long rather than any. The only time it is null is when it is deleted.

Thanks,

Eliot</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59494</commentid>
    <comment_count>4</comment_count>
    <who name="Kyle Huey">me</who>
    <bug_when>2011-11-02 15:21:50 +0000</bug_when>
    <thetext>(In reply to comment #3)
&gt; Fixed in the 1 November Editor&apos;s Draft:
&gt; 
&gt; interface IDBVersionChangeEvent : Event {
&gt;     readonly attribute unsigned long long oldVersion;
&gt;     readonly attribute unsigned long long newVersion;
&gt;     void initIDBVersionChangeEvent (DOMString typeArg, boolean canBubbleArg,
&gt; boolean cancelableArg, long long oldVersion, long long newVersion);
&gt; };
&gt; 
&gt; I think newVersion should be long long rather than any. The only time it is
&gt; null is when it is deleted.

It should be nullable (&quot;unsigned long long?&quot;) then, right?

/me admits to not knowing much about this whole WebIDL thing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>59497</commentid>
    <comment_count>5</comment_count>
    <who name="Ms2ger">Ms2ger</who>
    <bug_when>2011-11-02 15:48:39 +0000</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; Fixed in the 1 November Editor&apos;s Draft:
&gt; &gt; 
&gt; &gt; interface IDBVersionChangeEvent : Event {
&gt; &gt;     readonly attribute unsigned long long oldVersion;
&gt; &gt;     readonly attribute unsigned long long newVersion;
&gt; &gt;     void initIDBVersionChangeEvent (DOMString typeArg, boolean canBubbleArg,
&gt; &gt; boolean cancelableArg, long long oldVersion, long long newVersion);
&gt; &gt; };
&gt; &gt; 
&gt; &gt; I think newVersion should be long long rather than any. The only time it is
&gt; &gt; null is when it is deleted.
&gt; 
&gt; It should be nullable (&quot;unsigned long long?&quot;) then, right?

Yes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>62068</commentid>
    <comment_count>6</comment_count>
    <who name="Eliot Graff">eliotgra</who>
    <bug_when>2011-12-27 22:03:28 +0000</bug_when>
    <thetext>made all appropriate elements nullable, in the following:
IDBVersionChangeEvent.oldversion
IDBVersionChangeEvent.newversion
IDBVersionChangeEvent.initIDBVersionChangeEvent()

IDBFactory.open()

IDBDatabase.version

IDBFactorySync.open()

IDBDatabaseSync.version

IDBVersionChangeCallback.transactionStarted()

Changes are published in the Editor&apos;s Draft of Dec 27.

Thanks,

Eliot</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63037</commentid>
    <comment_count>7</comment_count>
    <who name="Jonas Sicking (Not reading bugmail)">jonas</who>
    <bug_when>2012-01-24 04:57:30 +0000</bug_when>
    <thetext>Actually, only the newVersion property on the IDBVersionChangeEvent can be null. All other version properties/arguments are always non-null. Changed things to reflect this.

I also removed the initIDBVersionChangeEvent function in favor of a constructor since that&apos;s how DOM-Events are initialized these days.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>