1184 2005-04-01 09:11:09 +0000 markup validator ignores SYSTEM doctypes 2005-06-03 00:15:15 +0000 1 1 1 Unclassified Validator check 0.7.0 All All RESOLVED FIXED http://www.w3.org/Style/ P2 critical --- 856 1 ot ot www-validator-cvs oldest_to_newest 3862 0 ot 2005-04-01 09:11:09 +0000 0.7.0dev seems to have trouble recognizing custom DTDs, even moreso than <= 0.6.7 e.g 1) http://www.yoyodesign.org/doc/dtd/demo/frameset.php?yoyolng=en or 2) http://www.w3.org/Style/ 0.6.7 declares 1) invalid, but no error given, and declares 2) valid current CVS version claims "This page is not Valid (no Doctype found)!" for both. 3812 1 385 ot 2005-04-06 04:27:11 +0000 Created attachment 385 remove redundant code and rewrite core feature of sub preparse_doctype() 3553 2 ot 2005-05-09 05:49:36 +0000 This bug was twofold: 1)- a recent modification in sgml.soc (the sgml catalog in the sgml-lib used by, and distributed with, the validator), aiming at giving warnings when a bogus FPI was use with a good system identifier, was in effect ignoring the system identifier, even when that should not be the case 2)- the doctype detection code (currently in check, &preparse_doctype(), previously &preparse(), and before that probably in something named detect_doctype()...) never detected the presence of a doctype in the case of a SYSTEM declaration, only PUBLIC 3)- version 0.7.0 of check is stricter with its handling of documents without recognized doctypes, and forces the fallback to a known doctype instead of accepting documents as "valid <BLANK>". This new situation is not a bug per se, rather a bug fix, but it made the issue described in point 2) apparent. Suggested fixes: - 1) was fixed by revision 1.16 of http://dev.w3.org/cvsweb/validator/htdocs/sgml-lib/sgml.soc - the collision of 2) and 3) can be fixed by changing preparse_doctype to also recognise SYSTEM doctypes. I will commit such a patch later today. - as also discussed earlier, changing the model from valid/invalid foo to no/n error(s) found would also avoid such issues, but this is not planned (yet). 3016 3 ot 2005-06-03 00:15:15 +0000 http://dev.w3.org/cvsweb/validator/httpd/cgi-bin/check#rev1.416 seems to fix this by recording into $File->{Doctype} the FPI if present, the SI otherwise, both for PUBLIC and SYSTEM doctypes. The change is not http://www.w3.org/Bugs/Public/attachment.cgi?id=385 (that one was rejected), but a minor change in regexp within preparse_doctype() 385 2005-04-06 04:27:11 +0000 2005-04-06 04:27:11 +0000 remove redundant code and rewrite core feature of sub preparse_doctype() check_preparse_doctype.patch text/plain 1746 ot SW5kZXg6IGNoZWNrCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1YmxpYy92YWxpZGF0 b3IvaHR0cGQvY2dpLWJpbi9jaGVjayx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40MTMKZGlmZiAt dSAtcjEuNDEzIGNoZWNrCi0tLSBjaGVjawkzMSBNYXIgMjAwNSAyMTozMzowNCAtMDAwMAkxLjQx MworKysgY2hlY2sJNiBBcHIgMjAwNSAwNDoyNTowOSAtMDAwMApAQCAtMTcyNCwxNiArMTcyNCwx MCBAQAogc3ViIHByZXBhcnNlX2RvY3R5cGUgewogICBteSAkRmlsZSA9IHNoaWZ0OwogCi0gICMK LSAgIyBSZXNldCBET0NUWVBFLCBSb290IChmb3Igc2Vjb25kIGludm9jYXRpb24sIHByb2JhYmx5 IG5vdCBuZWVkZWQgYW55bW9yZSkuCi0gICRGaWxlLT57RE9DVFlQRX0gICAgICAgICA9ICcnOwot ICAkRmlsZS0+e1Jvb3R9ICAgICAgICAgICAgPSAnJzsKLQogICBteSAkZHRkID0gc3ViIHsKICAg ICByZXR1cm4gaWYgJEZpbGUtPntSb290fTsKLSAgICAoJEZpbGUtPntSb290fSwgJEZpbGUtPntE T0NUWVBFfSkgPSBzaGlmdCA9fiAgbSg8IURPQ1RZUEVccysoXHcrKVxzK1BVQkxJQ1xzKyg/Oltc J1wiXSkoW15cIlwnXSspKD86W1wiXCddKS4qPilzaTsKICAgfTsKLQorICAKICAgbXkgJHN0YXJ0 ID0gc3ViIHsKICAgICBteSAkdGFnICA9IHNoaWZ0OwogICAgIG15ICRhdHRyID0gc2hpZnQ7CkBA IC0xNzQ3LDE0ICsxNzQxLDI1IEBACiAgICAgaWYgKCRhdHRyLT57eG1sbnN9KSB7JEZpbGUtPntO YW1lc3BhY2V9ID0gJGF0dHItPnt4bWxuc319OwogICB9OwogCi0gIG15ICRwID0gSFRNTDo6UGFy c2VyLT5uZXcoYXBpX3ZlcnNpb24gPT4gMyk7Ci0gICRwLT54bWxfbW9kZShUUlVFKTsKLSAgJHAt Pmlnbm9yZV9lbGVtZW50cygnQk9EWScpOwotICAkcC0+aWdub3JlX2VsZW1lbnRzKCdib2R5Jyk7 Ci0gICRwLT5oYW5kbGVyKGRlY2xhcmF0aW9uID0+ICRkdGQsICd0ZXh0Jyk7Ci0gICRwLT5oYW5k bGVyKHN0YXJ0ID0+ICRzdGFydCwgJ3RhZyxhdHRyJyk7Ci0gICRwLT5wYXJzZShqb2luICJcbiIs IEB7JEZpbGUtPntDb250ZW50fX0pOwogCisgIGlmICghICRGaWxlLT57RE9DVFlQRX0peworICAg IG15ICRhbGxjb250ZW50ID0gam9pbiAiXG4iLCBAeyRGaWxlLT57Q29udGVudH19OworICAgIGlm ICgkYWxsY29udGVudCA9fiAvPCFET0NUWVBFKFtePl0qKT4vaXNvKXsKKyAgICAgIG15ICRnZW5l cmljZG9jdHlwZSA9ICQxOworICAgICAgJF8gPSAkZ2VuZXJpY2RvY3R5cGU7CisgICAgICBpZiAo bTouKFx3KylccytQVUJMSUNccysoLiopOmlzbykKKyAgICAgICAgeyAgCisgICAgICAgICAgbXkg JHB1YmxpY2RvY3R5cGUgPSAkMjsKKyAgICAgICAgICAkcHVibGljZG9jdHlwZSA9fiBtL1tcIlwn XShbXlwiXCddKylbXCJcJ10vOworICAgICAgICAgICRGaWxlLT57RE9DVFlQRX0gPSAkMTsKKyAg ICAgICAgfQorICAgICAgZWxzaWYgKG06KFx3KylccytTWVNURU1ccytbXCJcJ10oLiopW1wiXCdd OmlzbykKKyAgICAgICAgeworICAgICAgICAgICMgbm90aGluZyB5ZXQKKyAgICAgICAgfQorICAg ICAgICAKKyAgICAgIH0KKyAgfQogICAkRmlsZS0+e0RPQ1RZUEV9ID0gJycgdW5sZXNzIGRlZmlu ZWQgJEZpbGUtPntET0NUWVBFfTsKICAgJEZpbGUtPntET0NUWVBFfSA9fiBzKF5ccyspeyB9ZzsK ICAgJEZpbGUtPntET0NUWVBFfSA9fiBzKFxzKyQpeyB9ZzsK