10221 2010-07-21 20:27:41 +0000 Always coalesce adjacent text nodes even in the case where the previous node was not the one last inserted by the parser. 2010-10-04 13:59:55 +0000 1 1 1 Unclassified HTML WG pre-LC1 HTML5 spec (editor: Ian Hickson) unspecified PC All RESOLVED FIXED P1 critical --- 1 james ian eric hsivonen ian mike public-html-admin public-html-wg-issue-tracking w3c public-html-bugzilla oldest_to_newest 37052 0 james 2010-07-21 20:27:41 +0000 Always coalesce adjacent text nodes even in the case where the previous node was not the one last inserted by the parser. For markup like <table> a <tr></tr> b <tr></tr> The spec currently requires two text nodes to be created, one for "a" and one for "b". This is different to the usual behaviour where adjacent text nodes are coalesced. The original reason for the change was to defend against N^2 behaviour from growing the text buffer. However this behaviour is not implemented by Gecko or (I believe) WebKit ToT. Nor is it implemented in html5lib and indeed is a problem for some non-DOM tree formats that have no concept of text nodes. It is possible to prevent the N^2 behaviour with a sufficiently clever implementation. Given this, the spec should revert to coalesce always. 37063 1 hsivonen 2010-07-22 08:24:48 +0000 My current thinking is that the parser should coalesce. If that's a perf problem when the node size gets very large, then I think implementors should invoke the DoS avoidance limits trump card cause in the spec and not coalesce too large nodes in any situation--be it foster-parenting, document.write() or discretionary flushes for incremental layout of huge text nodes. 37471 2 ian 2010-08-16 20:38:14 +0000 EDITOR'S RESPONSE: This is an Editor's Response to your comment. If you are satisfied with this response, please change the state of this bug to CLOSED. If you have additional information and would like the editor to reconsider, please reopen this bug. If you would like to escalate the issue to the full HTML Working Group, please add the TrackerRequest keyword to this bug, and suggest title and text for the tracker issue; or you may create a tracker issue yourself, if you are able to do so. For more details, see this document: http://dev.w3.org/html5/decision-policy/decision-policy.html Status: Accepted Change Description: see diff given below Rationale: Concurred with reporter's comments. This is going to lead to some very interesting test cases. I especially like this one (listed in the spec): A<script> var text = document.getElementsByTagName('script')[0].firstChild; text.data = 'B'; document.body.appendChild(text); </script>C (Should result in two text nodes.) 37472 3 contributor 2010-08-16 20:38:56 +0000 Checked in as WHATWG revision r5298. Check-in comment: Coalesce text nodes even if they're not parser-inserted. http://html5.org/tools/web-apps-tracker?from=5297&to=5298