16:57:06 RRSAgent has joined #webdriver 16:57:11 logging to https://www.w3.org/2024/11/13-webdriver-irc 16:57:11 Zakim has joined #webdriver 16:58:21 rrsagent, set world-visible 16:58:21 I'm logging. I don't understand 'set world-visible', AutomatedTester. Try /msg RRSAgent help 16:59:04 rrsagent, set logs world-visible 16:59:19 orkon has joined #webdriver 16:59:26 Meeting: Browser Testing and Tools - November 2024 16:59:35 Chair: David Burns 16:59:42 Agenda: https://www.w3.org/wiki/WebDriver/2024-11-BiDi 17:00:24 Scribe: David Burns 17:00:32 ScribeNick: AutomatedTester 17:00:45 RRSAgent, create minutes 17:00:46 I have made the request to generate https://www.w3.org/2024/11/13-webdriver-minutes.html AutomatedTester 17:00:53 present+ 17:00:54 present+ 17:01:06 jgraham has joined #webdriver 17:01:38 RRSAgent, pointer 17:01:38 See https://www.w3.org/2024/11/13-webdriver-irc#T17-01-38 17:01:44 whimboo has joined #webdriver 17:01:51 jdescottes has joined #webdriver 17:01:52 present+ 17:01:55 present+ 17:02:00 sasha has joined #webdriver 17:02:04 present+ 17:02:10 present+ 17:02:12 present+ 17:03:15 present+ 17:07:34 topic: Expose initiatorType and destination on network.Reques 17:07:43 github: https://github.com/w3c/webdriver-bidi/pull/809 17:08:02 jgraham: when we first did the networkj request events 17:08:40 ... we had network.initiator which ahd a type field to mirror what was in cdp. We never really figured that out and it's not being used 17:08:50 whimboo has joined #webdriver 17:09:13 ... but now fetch has the same use cases for the initatorType and this PR has all of this 17:09:29 ... and there is a plan that we can deprecate the previous way of doing this 17:10:01 ... are there any remaining concerns on this proposal? 17:10:10 q+ 17:10:15 ack next 17:10:48 whimboo: I wanted to mention this is a property that would fully unblock cypress sooner 17:11:42 ... Cypress is planning a major release next year and they want to show that they have bidi support 17:12:08 topic: Restore behavior of wait for navigation to complete when a user prompt is opened 17:12:19 github: https://github.com/w3c/webdriver/issues/1857 17:13:04 whimboo: we have had someone spot a regresdsion when we have an alert open with navigation to complete 17:13:30 ... we aren't waiting for the alert, we return immediately saying timeout 17:14:13 ... my question is "Do we want to return early if there is an alert?" I think it would be better if we were to return immediately 17:14:20 q? 17:15:21 Topic: Should a navigation clean-up the browsing context input state map? 17:15:31 github: https://github.com/w3c/webdriver/issues/1859 17:16:12 whimboo: It looks. like there is a broken understanding between browsing context and navigator 17:17:01 ... this is likely an issue from the move between browsing context and navigator. Do we need to fix everything or can we go fix the actions first by themselves 17:18:08 q+ 17:18:22 ... when speaking to orkon there are hundreds of cases that may need to be updated in the classic spec. do we want to change one or everything? 17:18:25 ack next 17:18:35 etnbrd has joined #webdriver 17:18:48 s/this is likely an issue from the move between browsing context and navigator/this is likely an issue from the move between browsing context and navigable 17:18:55 jimevans has joined #webdriver 17:19:07 orkon: I think that this is the same problem when we were moving to navigable before with the html spec 17:19:09 q+ 17:19:55 present+ 17:19:55 ... i think it probably makes sense to at least have a note with browsing context meaning navigable and replace all of them to prevent any confusion between commands 17:19:59 ack next 17:20:30 jgraham: I think every use of browsing context means navigable. 17:20:58 q+ 17:21:28 ... 17:21:46 ack next 17:22:35 whimboo: given that it should survive navigation then we can close this issue so we don't want to fix this as one item 17:22:40 simons has joined #webdriver 17:23:03 q+ 17:23:05 jgraham: the way that orkon did this for bidi was a good way to do it for the classic. It will be a rather large PR 17:23:09 present+ 17:23:09 ack next 17:24:26 orkon: unrelated, I noticed that bikeshed allows combining files into a spec. I wonder if we can use this to make it simpler to move things across as there are similarities in the spec. 17:24:27 q? 17:24:48 highfivedenis has joined #webdriver 17:25:19 topic: Include stacktrace into log messages 17:25:30 github-bot: https://github.com/w3c/webdriver-bidi/pull/807 17:25:30 AutomatedTester, Sorry, I don't understand that command. Try 'help'. 17:25:45 github: https://github.com/w3c/webdriver-bidi/pull/807 17:25:47 q+ 17:25:56 ack next 17:26:18 orkon: this is a PR/issue about stacktrace not being part of the log messages 17:26:39 whimboo has joined #webdriver 17:27:02 ... this was originally excluded but they have come up with a use case to ignore log messages if it comes from a "third party script". 17:27:03 q+ 17:27:18 ... I am now wondering if we should include stacktraces to all console logs? 17:27:20 ack next 17:27:44 q+ 17:27:59 q+ 17:28:21 whimboo: I think it would be fine to add it. I think it would add it to console logging? I wonder if we want to all people to opt into this extra info as it could add a lot of info 17:28:25 ack next 17:28:56 jgraham: I was going to say something similar. I don't know if it is expensive to compute a stacktrace as it could be expensive 17:29:18 ... this could lead into the subscription discussion later 17:30:05 ... I think it would be good to have a way of config if you don't want debug messages you can exclude them and do we want to opt into stacktraces. It merits a discussion 17:30:09 ack next 17:30:48 sadym: I didn't mean that we add configuration to the subscription. I don't want to send them by default, just if the user subscribes it 17:31:09 q+ 17:31:10 ... and users can limit the info being passed back with preload script 17:31:14 ack next 17:32:05 q+ 17:32:07 jdescottes: I think that stacktraces are there for most things, have a way to add it already and support adding it in this scenario 17:32:09 ack next 17:32:37 jgraham: Let's add it by default and if we need filtering we can add that at a later stage 17:32:38 q+ 17:32:41 ack next 17:32:57 q+ 17:33:11 whimboo: could someone submit a PR that updates and adds stacktrace 17:33:19 ... or I can try do it next week 17:33:35 ack next 17:33:54 orkon: this is in the console spec already 17:34:15 whimboo: we don't have this in firefox yet so I think we may need the spec changes 17:34:16 q? 17:34:17 see also https://github.com/whatwg/console/issues/203 17:34:32 whimboo: I have put a link to the issue above 17:34:38 RRSAgent, make minutes 17:34:39 I have made the request to generate https://www.w3.org/2024/11/13-webdriver-minutes.html AutomatedTester 17:34:45 q? 17:35:01 sadym: we already send stacktrace for logEntry 17:35:19 topic: Allow applying preload scripts to opened contexts 17:35:30 github: https://github.com/w3c/webdriver-bidi/pull/803 17:35:57 orkon: this is one of the. topics that was brought up by the playwright folks 17:36:02 q+ 17:36:22 ... this is the PR that prepared to implements inheritance for preload scripts 17:36:41 q+ 17:36:45 ... I wonder if there are concerns with this approach and would this have an issue with the events being sent out? 17:36:49 ack next 17:37:00 jgraham: I think we shouild do this 17:37:39 ... we should be looking to add global configuration or top level traversibles be documented 17:37:56 sasha has joined #webdriver 17:38:15 ... I agree we should be doing this but I think we need to be aware of all the different ways that we should bve doing this 17:38:25 q? 17:38:28 ack next 17:39:07 sadym: this looks like a new mechanism. I wonder if this playwright appraoch could not be handled with using preload script globally 17:39:18 jgraham: I think it could but that might be harder 17:40:03 ... people would want it a per context and I think we want it inheritable. They are both required 17:40:06 q? 17:40:27 topic: Subscription IDs for events 17:40:41 github: https://github.com/w3c/webdriver-bidi/pull/810 17:41:03 orkon: this is a continuation of the previous topic 17:41:31 ... I have been reworking this to make sure that we can inherit events 17:41:38 q+ 17:41:57 ... I have tried to get all the use cases but I am not sure that I ahve got them all 17:42:20 ... should we add subscription IDs or should we use the current way of doing it without IDs 17:42:24 ack next 17:42:44 jgraham: I like the subscription id approach is good 17:43:30 ... jdescottes brought this up for when working on tests so we can unscribe from events that are not related to what we are wroking on. e.g. harness events vs user events 17:44:20 ... 17:44:46 ... it might be easier to have it just as a list of events we want to handle 17:45:23 q? 17:45:37 topic: Support finding iframe elements by browsing context id 17:45:46 github: https://github.com/w3c/webdriver-bidi/issues/794 17:46:27 orkon: proposal of a way to find the container of the navigable by browsing context id 17:46:44 ... there is a request from playwright and puppeteer 17:47:18 ... there are multple ways that we can do this. I have written a PR of this is 17:47:37 ... there is another way that whimboo suggested 17:47:48 q+ 17:47:54 ... I like this way as it like how we locate DOM nodes 17:47:59 ack next 17:47:59 q+ 17:48:00 q+ 17:48:26 simons: I think that it should be a locator as that is how classic/selenium does this 17:48:50 there is one wrinkle that people like to find iframes by id or name 17:48:55 ack next 17:50:06 jgraham: This is about finding iframes in a navigable which is different to classic. Using a locator feels weird but I can see the appeal 17:50:16 ... I think that I would prefer a different command 17:50:29 q- 17:50:41 q+ 17:50:41 ... perhaps actually this is going to be fine and won't make much difference. I am happy the PR mostly as it is 17:50:49 ack next 17:51:52 orkon: regarding this PR. At the moment we discard the locator... I wonder if there is and should we throw an error when using the locator or should we just ignore them 17:52:03 q? 17:52:05 q+ 17:52:36 jgraham: is the second question more of a CDDL question? 17:53:34 orkon: not really... this there are other attributes 17:54:00 ... and they are optional fields 17:54:15 jgraham: I think this is pushing me to this a new command 17:54:35 q+ 17:54:45 q- 17:54:47 ... there is something to be said about having a command that doesn't take invalid commands 17:54:49 ack next 17:55:23 sadym: if we send command with locate nodes and then get a browsing context 17:55:29 orkon: yes... 17:55:59 sadym: this feels wrong. We are going to need to send other fields here 17:56:18 q+ 17:57:13 orkon: we could have the search from the parent context to return the child 17:57:32 sadym: this would change the way that the command works and feels weird 17:57:59 jgraham: if we need to call getTree to be able to use the command that complicates this 17:58:47 RRSAgent, make minutes 17:58:48 I have made the request to generate https://www.w3.org/2024/11/13-webdriver-minutes.html jgraham 17:58:54 ack next 17:59:23 topic: WPT RFC-214 Add testdriver features 17:59:35 github: https://github.com/web-platform-tests/rfcs/pull/214 18:00:41 sadym: please can everyone have a look at this. It's not directly releated to this group but could gsnedders and jgraham and others please review 18:03:39 RRSAgent, make minutes 18:03:40 I have made the request to generate https://www.w3.org/2024/11/13-webdriver-minutes.html AutomatedTester 20:21:49 Zakim has left #webdriver