14:02:57 RRSAgent has joined #wot-discovery 14:02:57 logging to https://www.w3.org/2021/06/07-wot-discovery-irc 14:03:02 meeting: WoT Discovery 14:03:52 FarshidT_ has joined #wot-discovery 14:04:11 present+ Kaz_Ashimura, Andrea_Cimmino, Chrstian_Glomb, Ege_Korkan, Farshid_Tavakolizadeh, Kunihiko_Toumura 14:05:33 cris_ has joined #wot-discovery 14:05:46 present+ Michael_McCool 14:08:01 topic: minutes 14:08:24 mc: we review different PRs 14:08:33 s/review/reviewed/ 14:08:47 mc: I recently worked on TD signatures, some updates later 14:08:52 i|we review|-> https://www.w3.org/2021/05/31-wot-discovery-minutes.html May-31| 14:09:07 i/we review/scribenick: cris_/ 14:09:21 ... we accepted different refactoring PRs 14:09:47 ... farshid have you completed the updates to the mentioned PRs? 14:09:52 farshid: yes 14:10:16 mc: I have not yet discussed about slack with Kaz 14:10:20 ... but we have time 14:11:12 ... any objection to publish the minutes? 14:11:18 ... ok minutes accepted 14:11:34 topic: Pending PRs 14:12:21 mc: let's start simple, PR 192 is about change log 14:12:30 ... farshid already reviewed and approved it 14:12:37 ... we can fix it up later 14:12:47 if we find any issues 14:12:58 s/if/... if/ 14:13:05 ... any objection? 14:13:25 farshid: not an objection but it would be cool to have dates or timestamps for features 14:13:46 mc: it should be new changes after the last WD 14:14:02 ... anyway we'll fix it later 14:14:29 i/let's start/subtopic: PR 192/ 14:14:40 i|let's start|-> https://github.com/w3c/wot-discovery/pull/192 PR 192 - Addition of change log WD2| 14:15:11 subtopic: PR 195 14:15:20 mc: another easy one, it is just a bug fix 14:15:29 ... any comments? 14:15:49 ... ok merged 14:17:50 mc: does the sub prs provide all the changes requested by Ben? 14:18:10 farshid: they contain more than that, some updates in the text for example 14:18:32 mc: Ok I'll propose to merge them and than close the original now. 14:18:40 subtopic: PR 191 14:19:01 farshid: we reviewed it last time 14:19:04 mc: seems ok 14:19:09 ... merged 14:19:32 subtopic: PR 196 14:19:49 mc: no review from Ben here 14:20:10 i|we reviewed|-> https://github.com/w3c/wot-discovery/pull/191 PR 191 - Refactor Directory Service API TD (retrieve one and search as actions, listing as things property)| 14:20:41 farshid: now we have three affordances 14:20:47 i|no review|-> https://github.com/w3c/wot-discovery/pull/196 PR 196 - Refactor Directory Service API TD (split events)| 14:20:49 ... all nouns 14:21:18 ... we don't have type for partial TD 14:21:45 mc: diff is confusing 14:21:49 ... in the created event 14:22:02 farshid: it was called full 14:22:25 ... it was clashing with the update parameter 14:22:34 ... diff is more consistent 14:22:55 mc: is ok for now, let's go on and see if it works out 14:24:04 ... we can improve the text a little bit by saying that some query parameters are ignored for a particular event type 14:24:22 ... I am ok with the current shape, adding a small point 14:26:09 ... any objection to merge it? 14:26:13 ... merged 14:26:39 subtopic: PR 198 14:27:09 farshid: this is a change in the api, not just a refactoring 14:27:19 i|this is|-> https://github.com/w3c/wot-discovery/pull/198 PR 198 - Notification API: pass event type in HTTP path instead of query| 14:27:27 ... you can now subscribe to two event types at a time 14:29:42 mc: it is a little bit protocol specific 14:29:50 farshid: but also extensible 14:30:07 mc: url should be opaque in general 14:30:12 ... I am ok merging it 14:31:55 farshid: actually you are right td does not allow Event filtering 14:32:09 ege: you could use a subscription payload to achive it 14:32:19 mc: to be discussed in the TD it self 14:32:33 ... filtering by urls is better than nothing 14:32:45 ege: here is custom workaround 14:32:51 ... for the td we need something generic 14:33:45 cris: yeah maybe something like a root form 14:35:30 mc creating an issue about subscribing to a subset of events 14:36:05 subtopic: 184 14:36:27 mc: this is the original pr, we agreed to close it without merging cause it got replaced by the other one 14:36:37 farshid: there was also an issue 14:36:46 ... 133 14:36:54 https://github.com/w3c/wot-discovery/issues/133 14:36:58 McCool has joined #wot-discovery 14:37:02 i|this is the|-> https://github.com/w3c/wot-discovery/pull/184 PR 184 - Refactor Directory Service API TD| 14:37:03 https://github.com/w3c/wot-discovery/issues/133 14:37:03 https://github.com/w3c/wot-discovery/issues/133 14:38:22 mc: ok PR closed 14:39:07 ... closing also the issue 14:39:17 ... above 14:40:22 topic: testing 14:40:38 mc: farshid can you attend testing calls? 14:41:14 farshid: yes I'll be there on Wednesday and Friday? 14:41:25 s/?// 14:41:35 ege: we need a testing plan 14:41:53 mc: what are the features that we need to test? 14:42:08 ... we need a fine tuned test suite 14:42:20 ... not just comply to our TM 14:42:33 ege: we need to interact with an API 14:42:36 mc: I think so 14:42:54 mc: there is also peer-to-peer 14:43:03 ege: how would it looks like? 14:43:15 mc: there's also introduction 14:43:42 ... if the state is observable we need to check it 14:44:00 ... but there might be apis where the state is private 14:44:09 ... triggering errors might work 14:44:16 ... what do we have for testing? 14:44:26 farshid: we have a full test suite for go 14:44:41 ... it would be really cool to have it in python 14:44:51 ege: we just need the output 14:45:16 farshid: yeah but how to use for other implementations? 14:46:37 mc: we should create an id for each testable feature 14:46:48 ... and create an csv file 14:47:09 ege: we don't need a brand new test suite 14:47:15 ... just a tool to run 14:47:19 ... and the output 14:47:43 mc: what is required by w3c is a test result and a test plan 14:47:49 ... it comes to us to define features 14:48:17 ... we don't even need to check your code 14:48:34 farshid: the suite is test oriented 14:48:46 tdd-reg-create-known-td 14:50:03 farshid: how would we report optional features? 14:50:30 mc: just put everything pass or fail than we can later ignore it 14:52:10 farshid: if you are getting or patching there are many things to verify 14:52:33 ege: for creation for example there should be two child assertions 14:53:06 mc: why don't we try to use Farshid suite and name each test with unique name? 14:53:22 ... and understand the feature map we need 14:53:25 farshid: ok 14:53:51 mc: farshid does not have sparql support 14:54:01 ... andrea does not have jsonpath there 14:54:11 andrea: not yet 14:54:51 @farshid is this the running tests for linksmart: https://github.com/linksmart/thing-directory/blob/master/catalog/http_test.go 14:55:27 s/not yet/yes it supports jsonpath, but we don't have tests for it/ 14:55:44 mc: ok we have few months to fill up the gaps 14:55:58 ... do we have a existing test suite for jsonpath? 14:56:10 andrea: I don't know, we have it for sparql 14:56:55 ... the benchmarks generate the data and than test it with queries 14:57:13 ... I have to check if this can be adapted for TDs 14:57:31 mc: ok to define a plan 14:57:53 ... but which version of the spec we will use 14:58:01 ... I would use the current draft 14:58:21 rrsagent, make log public 14:58:27 rrsagent, draft minutes 14:58:27 I have made the request to generate https://www.w3.org/2021/06/07-wot-discovery-minutes.html kaz 14:58:35 ... we should freeze the editor draft 14:58:58 ... for the next two weeks and then use the report to pin point gaps etc. 14:59:11 farshid: can we do editorial changes 14:59:13 mc: yes 14:59:58 farshid: I can provide tests for multi cast dns 15:00:10 zakim, who is on the call? 15:00:10 Present: Kaz_Ashimura, Andrea_Cimmino, Chrstian_Glomb, Ege_Korkan, Farshid_Tavakolizadeh, Kunihiko_Toumura, Michael_McCool 15:00:17 mc: we can't test qr code 15:00:36 ... we just test things that we defined changes to other standards like the service type 15:00:51 present+ Cristiano_Aguzzi 15:01:10 rrsagent, draft minutes 15:01:10 I have made the request to generate https://www.w3.org/2021/06/07-wot-discovery-minutes.html kaz 15:01:41 mc: also we need to test security 15:02:43 mc: please check if there are some test suite for json-path 15:04:12 mc: closing the meeting see you tomorrow in the test call 15:04:15 [adjourned] 15:04:18 rrsagent, draft minutes 15:04:18 I have made the request to generate https://www.w3.org/2021/06/07-wot-discovery-minutes.html kaz