Review Report on section 8.5.x (Border property) ~= 260 testcases

Hello all,

This report is mostly for Fantasai and Arron E.

Summary (mostly for Fantasai and Arron)
***************************************
- the assertion text of
border-*-style set to 'hidden' testcases (4 testcases):
http://test.csswg.org/suites/css2.1/20100815/html4/border-*-style-002.htm
need to be adjusted. The assertion text for those 4 testcases is not
accurately true and suggest something wrong.
- 5 fractional pixel problem testcases were found and I have proposed
replacements for these: do a text search in this email for "Fractional
pixel problem!"
-
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-095.htm
and
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-095.htm
could be redone, could be improved, could be designed differently
- many testcases with div {height: 1in} which is unneeded in those
testcases
- 16 display: list-item testcases ( border-*-applies-to-010.htm ) which
do not state that a bullet list-marker should be rendered and where
- many border-collapse: collapse declarations which are all unneeded
-
http://test.csswg.org/suites/css2.1/20100815/html4/c5517-brdr-s-000.htm
(I. Hickson) should be adjusted, improved with p {padding: 1em;}
- 3 precise issues have not been covered by testcases in the test suite:
  a) border-width explicitly inheriting from the parent with a
border-style: hidden. With 'border-style: none', this has been tested.
  Proposed testcase:
  http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-width-012.htm
  b) Percentage unit does not apply to border-width
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-width-013.htm
  c) Inherit applied to inherit border-style and border-width:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-width-014.htm



Section 8.5 (partial) review report
===================================

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5511-brdr-tw-000.htm

Why a table and cells for such test? Nevertheless,

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5511-brdr-tw-001.htm

Ideally, a text assert should state for that testcase that when the
element's border color is not specified, then the value of the element's
'color' property must be used for the border color.

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5511-brdr-tw-002.htm

Ideally, a text assert should state for that testcase that the initial
border-style value is 'none'.

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5511-brdr-tw-003.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5511-ibrdr-tw-000.htm

1- class="one" is not defined anywhere in this testcase; class="one" can
be safely removed from the testcase.
2- Ideally, a text assert should state for that testcase that the
initial border-style value is 'none'.

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5512-brdr-rw-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5512-brdr-rw-001.htm

Ideally, a text assert should state for that testcase that when the
element's border color is not specified, then the value of the element's
'color' property must be used for the border color.

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5512-brdr-rw-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5512-brdr-rw-003.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5512-ibrdr-rw-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5513-brdr-bw-000.htm

Why a table and cells for such test? Nevertheless,

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5513-brdr-bw-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5513-brdr-bw-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5513-brdr-bw-003.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5513-ibrdr-bw-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5514-brdr-lw-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5514-brdr-lw-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5514-brdr-lw-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5514-brdr-lw-003.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5514-ibrdr-lw-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5515-brdr-w-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5515-brdr-w-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5515-brdr-w-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5515-ibrdr-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5516-brdr-c-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5516-ibrdr-c-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5517-brdr-s-000.htm

The left and right borders are rather short: so, e.g., it may make
verifying the type of borders (left border and right border) difficult a
bit in some sentences. E.g.: <p class="nine">(...) Blue and grooved on
the left and right. The left and right borders are only 16px tall and
3px wide. There is very little chance realistically that a human would
be able to say that such elft and right borders are groove and not
ridge.

Suggestion: add p {padding: 1em;} so that left and right borders height
change from 16px to 48px and increase border-width everywhere, from
thick to 12px or 16px or more.

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5517-ibrdr-s-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5518-brdr-t-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5518-brdr-t-001.htm

"occurance" -> occurrence

s/over every occurance of the word/over every occurrence of the word/

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5518-ibrdr-t-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5519-brdr-r-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5519-brdr-r-001.htm

"occurance" -> occurrence

s/occurance/occurrence/

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5519-brdr-r-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5519-ibrdr-r-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5520-brdr-b-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5520-brdr-b-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5520-ibrdr-b-000.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5521-brdr-l-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5521-brdr-l-001.htm

"occurance" -> occurrence

s/occurance/occurrence/

   span, td { text-align: left; border-left: blue 2px solid; }
   table { border-collapse: separate; border-spacing: 6px; }

td is by default left-aligned; table border-collapse is separate by
default. So, the above could be replaced with the more compact code:

   span, td { border-left: blue 2px solid; }
   table { border-spacing: 6px; }


Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5521-brdr-l-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/c5521-ibrdr-l-000.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5522-brdr-000.htm

Suggestion:
p { color: blue; }
changed to
p { color: blue; padding: 1em;}
so that border left and border right are 32px taller.

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5522-brdr-001.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5522-brdr-002.htm

More compact code suggestion:

Change
   td, span {border: 2px solid blue;}
   table { border-collapse: separate; border-spacing: 6px; }

to

   td {border: 2px solid blue;}
   table { border-spacing: 6px; }

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/c5522-ibrdr-000.htm

There is no nested span in the testcase. So,

span span { color: silver; }
is irrelevant.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-003.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-004.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-005.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-006.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-007.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-012.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-013.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-014.htm

If pt unit is resolved the same way for border-width and height...
border-width and height properties must resolve fractional pixel the
same way: either both rounding up or both rounding down.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-015.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-016.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-017.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-018.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-023.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-024.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-025.htm

1 pica unit = 1/6 of an inch; so == 6px. So, 1pc border-width and 1pc
height should not trigger a fraction of a pixel.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-026.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-027.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-028.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-029.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-034.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-035.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-036.htm

Fractional pixel problem!

Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-bottom-width-036.htm

Rejected

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-037.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-038.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-039.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-040.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-045.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-046.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-047.htm

Fractional pixel problem!

Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-bottom-width-047.htm

Rejected

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-048.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-049.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-050.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-051.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-056.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-057.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-058.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-061.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-062.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-067.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-068.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-069.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-070.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-071.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-072.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-073.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-078.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-079.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-080.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-081.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-082.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-083.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-084.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-089.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-090.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-091.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-092.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-093.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-094.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-095.htm

div {height: 1in;} is not needed.

What may be missing are testcases with inherit for border-width when
border-style is none.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-001.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-002.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-003.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-004.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-005.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-006.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-007.htm

border-collapse: collapse; is not needed;
#cell {height: 1in;} is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-008.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-009.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-010.htm

The expected results should state that there should be a bullet
list-marker rendered.
height: 1in; is not required, not needed.

Proposed suggestion:

            div
            {
                border-bottom-style: solid;
                border-bottom-width: 1in;
                display: list-item;
                margin-left: 1em;
                width: 1in;
            }

<p>Test passes if there is a black square below. A black bullet (filled
disc) should appear on the left and above that black square.</p>

The same kind of proposed suggestion should also apply to other testcases
( border-*-applies-to-010.htm ) involving display: list-item:

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-width-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-width-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-color-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-color-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-style-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-style-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-style-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-style-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-applies-to-010.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-011.htm

height: 1in is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-012.htm

height: 1in is not needed. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-013.htm

border-collapse: collapse is not needed; #cell {height: 1in;} is not
required.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-014.htm

border-collapse: collapse is not needed; #cell {height: 1in;} is not
required.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-width-applies-to-015.htm

Reviewed and approved

----------------------

Author: Microsoft

In the following list of testcases

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-003.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-006.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-013.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-017.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-024.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-025.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-028.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-035.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-036.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-039.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-046.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-047.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-050.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-057.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-058.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-061.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-068.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-069.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-072.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-079.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-080.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-083.htm

the assert text ends with
"that sets the width of the bottom border."
and that should be changed into
"that sets the width of the left border."

In the following list of testcases

http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-003.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-006.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-013.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-017.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-024.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-025.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-028.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-035.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-036.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-039.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-046.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-047.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-050.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-057.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-058.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-061.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-068.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-069.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-072.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-079.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-080.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-083.htm

the assert text ends with
"that sets the width of the bottom border."
and that should be changed into
"that sets the width of the right border."

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-047.htm

Fractional pixel problem!

Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-left-width-047.htm

Rejected

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-080.htm

border-left-width: 1ex (12.8px rounded up to 13px in Firefox 3.6.8)
and width: 1ex (12.8px rounded up to 13px too in Firefox 3.6.8)
does not mean that there is no fractional pixel issue but here, in this
testcase, the 1ex length value is rounded the same way. It's possible
that this testcase could fail in other browser(s) due to fractional
pixel.

Required, needed adjustment:
 <meta name="assert" content="The 'border-left-width' property supports
a minimum plus one length value in 'ex' units that sets the width of
the bottom border.">

to replace to

 <meta name="assert" content="The 'border-left-width' property supports
a minimum plus one length value in 'ex' units that sets the width of
the left border.">

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-width-095.htm

Personally, I believe the testcase expected results should state that
the black box should be as wide as the black square because this is in
fact the decisive/deciding factor which should decide whether the
testcase is passed or failed.

This test is not ideal. All of the other border-left-width tests have 2
black shape one below the other, not side by side.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-047.htm

Fractional pixel problem!

Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-right-width-047.htm

Rejected

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-right-width-095.htm

Personally, I believe the testcase expected results should state that
the black box should be as wide as the black square because this is in
fact the decisive/deciding factor which should decide whether the
testcase is passed or failed.

This test is not ideal. All of the other border-right-width tests have 2
black shape one below the other, not side by side.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-width-036.htm

Fractional pixel problem!

Proposed replacement:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-top-width-036.htm

Rejected

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-width-080.htm

It seems that border-top-width: 1ex (12.8px) is rounded up the same as
height: 1ex in Firefox 3.6.8. It could be possible that a browser does
not round (up or down) the same for border-width and for height.

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-width-095.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-011.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-comparison-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-shorthand-001.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-shorthand-002.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-shorthand-003.htm

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-shorthand-004.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-color-175.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-right-color-175.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-left-style-011.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-right-style-011.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-style-011.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/border-width-011.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/double-border-width-001.htm

Reviewed and approved

**********************
Section 8.5.4
**********************

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-001.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-003.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-004.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-005.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-006.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-007.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-008.htm

These testcases goals could have been achieved without resorting to
abs-positioning and rel-positioning which, in these testcases, is a
debattable coding choice. Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-009.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-011.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-012.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-013.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-014.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-015.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-016.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-017.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-018.htm

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/border-dynamic-001.htm

Proposed modification:

To change the following

  <style type="text/css">
   .test { background: green; }
   .test div { margin: 10em 0; background: red; }
  </style>
 </head>

 <body>
  <p>There should be a big green box below.</p>
  <div id="test" class="test">
   <div></div>
  </div>
  <script type="text/javascript">
   var x = document.getElementById('test');
   x.clientHeight; // force reflow
   x.style.border = "solid lime";
  </script>

to

  <style type="text/css">
   #test { background: green; }
   #test div { margin: 10em 0; background: red; }
  </style>
 </head>

 <body>
  <p>There should be a big green box below with a bright green border
and there should be no red.</p>
  <div id="test">
   <div></div>
  </div>
  <script type="text/javascript">
   var x = document.getElementById('test');
   x.clientHeight; // force reflow
   x.style.border = "solid lime";
  </script>

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/border-dynamic-002.htm

Proposed modification:

To change the following

  <style type="text/css">
   .test { background: green; }
   .test div { margin: 10em 0; background: red; }
   .style { border: solid lime; }
  </style>
 </head>

 <body>
  <p>There should be a big green box below.</p>
  <div id="test" class="test">
   <div></div>
  </div>
  <script type="text/javascript">
   var x = document.getElementById('test');
   x.clientHeight; // force reflow
   x.className += " style";
  </script>

to

  <style type="text/css">
   #test { background: green; }
   #test div { margin: 10em 0; background: red; }
   .limeborder { border: solid lime; }
  </style>
 </head>

 <body>
  <p>There should be a big green box below.</p>
  <div id="test">
   <div></div>
  </div>
  <script type="text/javascript">
   var x = document.getElementById('test');
   x.clientHeight; // force reflow
   x.className = "limeborder";
  </script>

Reviewed and approved

----------------------

Author: Ian Hickson

http://test.csswg.org/suites/css2.1/20100815/html4/border-shorthands-001.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-shorthands-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-shorthands-003.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-001.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-003.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-004.htm

In all those testcases, div {height: 1in;} is not needed, not necessary.
Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-005.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-006.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-007.htm

In these testcases, div {height: 1in;} is not needed, not necessary.
Nevertheless,

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-008.htm

Reviewed and approved

----------------------

Author: Microsoft

http://test.csswg.org/suites/css2.1/20100815/html4/border-top-009.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-010.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-011.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-012.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-013.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-014.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-015.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-016.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-017.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-018.htm

In all those testcases, div {height: 1in;} is not needed, not necessary.
Nevertheless,

Reviewed and approved

-------------

Author: Microsoft

Border-left-style set to 'hidden' testcase:
http://test.csswg.org/suites/css2.1/20100815/html4/border-left-style-002.htm

and other border-*-style set to 'hidden' testcases:
http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-style-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-style-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-style-002.htm

Text assert says:
"
    The 'border-left-style' property set to 'hidden' does not render any
border for non-table elements.
"

but that is not accurately true. In fact, 'border-style: hidden' is more
reliable and systematic than 'border-style: none' when it comes to not
rendering any border. The text assert is suggesting that 'border-style:
hidden' may render border for table elements but that's not true.

The text assert should be saying instead:

"
    The 'border-left-style' property set to 'hidden' does not render any
border.
"

Section 17.6.2.1 Border conflict resolution
http://www.w3.org/TR/CSS21/tables.html#border-conflict-resolution
states:
"
Borders with a style of 'none' have the lowest priority. Only if the
border properties of all the elements meeting at this edge are 'none'
will the border be omitted
"

The same could be said of
http://test.csswg.org/suites/css2.1/20100815/html4/border-bottom-style-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-top-style-002.htm
http://test.csswg.org/suites/css2.1/20100815/html4/border-right-style-002.htm

So, it is, in fact, the 'border-style: none' testcases which should have
a note about not rendering borders for non-table elements but possibly
rendering a border for table elements due to border conflict resolution
algorithm in table elements.

-------------

Testcase apparently missing: border-width explicitly inheriting from the
parent with a border-style: hidden. With 'border-style: none', this has
been tested.

Proposed testcase:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-width-012.htm

Other testcases:
Percentage unit does not apply to border-width
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-width-013.htm

Inherit applied to inherit border-style and border-width:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/border-width-014.htm


regards, Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 test suite (beta 3; August 15th 2010):
http://test.csswg.org/suites/css2.1/20100815/html4/toc.html

CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/

Received on Thursday, 26 August 2010 01:11:35 UTC