- From: Kostiainen, Anssi <anssi.kostiainen@intel.com>
- Date: Thu, 22 May 2014 12:44:48 +0000
- To: Frederick Hirsch <w3c@fjhirsch.com>
- CC: W3C Device APIs WG <public-device-apis@w3.org>
[ Do we have some helpful Mozillian lurking on the list who’d like to take this forward? This could be a “good first bug” for someone who wants to get started contributing to the Mozilla codebase. ] On 16 May 2014, at 01:04, Frederick Hirsch <w3c@fjhirsch.com> wrote: > I took an action on today’s DAP call to check on whether the Firefox implementation is up to date with regards to the Vibration API specification. [...] Frederick - thanks for digging into the details. > (Note that the Firefox bug was reported since earlier Firefox threw an exception, which was a clear problem. This bug has been recorded as fixed > https://bugzilla.mozilla.org/show_bug.cgi?id=884935 ) > > We probably should discuss the intent of step 9 in the spec which allows an implementation to return false whatever reason - does that mean it does not need to strictly follow the earlier steps regarding truncation and max values? The spec change to add truncation was initiated based on this CR feedback: http://www.w3.org/2009/dap/track/issues/149 The changes landed to the spec in Jan 2014: http://lists.w3.org/Archives/Public/public-device-apis/2014Jan/0050.html If we look at the implementations listed at: https://www.w3.org/2009/dap/wiki/ImplementationStatus#Vibration_API We see that Chromium is up-to-date, and truncates as per the spec: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp&l=53 https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp&l=59 However, Mozilla's implementation returns false: http://lxr.mozilla.org/mozilla-central/source/dom/base/Navigator.cpp#793 http://lxr.mozilla.org/mozilla-central/source/dom/base/Navigator.cpp#797 > I suggest that it should not contradict the earlier steps and that Firefox needs another update to match the spec . If this is not the case we should add some clarifying text to the document. > > What do you think? I think Mozilla should update its implementation to match the latest spec: http://www.w3.org/TR/vibration/ Thanks, -Anssi
Received on Thursday, 22 May 2014 12:46:39 UTC